-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add AdityaP700 as a contributor for infra #1345
base: master
Are you sure you want to change the base?
Conversation
|
@AdityaP700 hey, can you open another PR please. Unfortunately, path filtering will not work for us. It is a known problem in GH that with path filtering the workflow is skipped, and it is a problem because we have branch protection that requires it to run - so merging is blocked please remove path filtering in new PR 🙏🏼 and if you are in mood to play with alternative like https://github.com/dorny/paths-filter, do it, but in a separate PR. We first need to quickly fix a bug in CI to unblock merging |
@derberg Sure, I’m looking into it! Well, the workflow with dorny/paths-filter will run while individual jobs get skipped, thus satisfying branch protection?,So, I guess I should proceed with the changes then. |
Quality Gate passedIssues Measures |
@derberg : i get your point ,okay so shall i create another PR in which i am thinking to add .all-contributorsrc to the paths exclusion list using !.all-contributorsrc and simplify/improve the bot detection logic to better handle cases where the PR might have been modified by a human after a bot initiated it. |
@AdityaP700 for now please just handle |
Adds @AdityaP700 as a contributor for infra.
This was requested by derberg in this comment