Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add AdityaP700 as a contributor for infra #1345

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @AdityaP700 as a contributor for infra.

This was requested by derberg in this comment

Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 71a4537

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@derberg
Copy link
Member

derberg commented Jan 29, 2025

@AdityaP700 hey, can you open another PR please. Unfortunately, path filtering will not work for us. It is a known problem in GH that with path filtering the workflow is skipped, and it is a problem because we have branch protection that requires it to run - so merging is blocked

please remove path filtering in new PR 🙏🏼

and if you are in mood to play with alternative like https://github.com/dorny/paths-filter, do it, but in a separate PR. We first need to quickly fix a bug in CI to unblock merging

@AdityaP700
Copy link
Contributor

AdityaP700 commented Jan 29, 2025

@derberg Sure, I’m looking into it! Well, the workflow with dorny/paths-filter will run while individual jobs get skipped, thus satisfying branch protection?,So, I guess I should proceed with the changes then.

Copy link

sonarqubecloud bot commented Feb 3, 2025

@derberg
Copy link
Member

derberg commented Feb 3, 2025

It doesn't work as expected. I saw below in logs

Screenshot 2025-02-03 at 14 59 15

also test still runs even though PR comes from bot, although it might be that last actor in the PR was me cause I did the merge of changes

--
please check the message from the logs, and also add .all-contributorsrc file to ignored list

@AdityaP700
Copy link
Contributor

@derberg : i get your point ,okay so shall i create another PR in which i am thinking to add .all-contributorsrc to the paths exclusion list using !.all-contributorsrc and simplify/improve the bot detection logic to better handle cases where the PR might have been modified by a human after a bot initiated it.

@derberg
Copy link
Member

derberg commented Feb 5, 2025

@AdityaP700 for now please just handle .all-contributorsrc case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants