Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security context for SpiceDB Operator #238

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Add security context for SpiceDB Operator #238

merged 2 commits into from
Aug 18, 2023

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Aug 16, 2023

Closes: #237

@jawnsy jawnsy requested a review from a team as a code owner August 16, 2023 21:23
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jawnsy
Copy link
Contributor Author

jawnsy commented Aug 16, 2023

I have read the CLA Document and I hereby sign the CLA

@jawnsy
Copy link
Contributor Author

jawnsy commented Aug 16, 2023

recheck

@jzelinskie jzelinskie added area/security Affects security area/tooling Affects the dev or user toolchain priority/3 low This would be nice to have labels Aug 16, 2023
ecordell
ecordell reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Left a couple of questions if you have a second.

config/operator.yaml Outdated Show resolved Hide resolved
config/operator.yaml Show resolved Hide resolved
config/operator.yaml Show resolved Hide resolved
@ecordell ecordell mentioned this pull request Aug 16, 2023
Merged
ecordell
ecordell approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell added this pull request to the merge queue Aug 18, 2023
Merged via the queue into authzed:main with commit 26c7d15 Aug 18, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
@jawnsy jawnsy deleted the operator-security-context branch August 18, 2023 22:46
@jawnsy jawnsy restored the operator-security-context branch August 18, 2023 22:46
@jawnsy jawnsy deleted the operator-security-context branch August 18, 2023 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecordell ecordell ecordell approved these changes

Assignees
No one assigned
Labels
area/security Affects security area/tooling Affects the dev or user toolchain priority/3 low This would be nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default security context settings for SpiceDB Operator
3 participants
@jawnsy @ecordell @jzelinskie