move e2e into its own go module and remove the runtime dependency on controller-runtime #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
rm-controller-runtime
branch
2 times, most recently
from
87ac507
to
f385f6c
Compare
ecordell
force-pushed
the
rm-controller-runtime
branch
2 times, most recently
from
68a8e28
to
50f5bda
Compare
controller-runtime (we still use it in tests).
ecordell
force-pushed
the
rm-controller-runtime
branch
from
50f5bda
to
f602d38
Compare
| @@ -11,7 +11,7 @@ on: # yamllint disable-line rule:truthy | |||
| branches: | |||
| - "*" | |||
| env: | |||
| GO_VERSION: "~1.19" | |||
| GO_VERSION: "~1.20" | |||
There was a problem hiding this comment.
move to 1.21 now that its out?
There was a problem hiding this comment.
we usually wait a little bit right? I figured we'd do spicedb first (I would want to move to the new stdlb slices/maps libs where possible too)
| @@ -16,7 +16,7 @@ func (c *Controller) PatchStatus(ctx context.Context, patch *v1alpha1.SpiceDBClu | |||
| } | |||
| patch.ManagedFields = nil | |||
| patch.Status.ObservedGeneration = patch.Generation | |||
| data, err := client.Apply.Data(patch) | |||
| data, err := json.Marshal(patch) | |||
There was a problem hiding this comment.
any semantic differences between this and the only Apply stuff?
There was a problem hiding this comment.
| @@ -62,7 +62,7 @@ func TestEnsureDeploymentHandler(t *testing.T) { | |||
| migrationHash: "testtesttesttest", | |||
| secretHash: "secret", | |||
| existingDeployments: []*appsv1.Deployment{{ObjectMeta: metav1.ObjectMeta{Annotations: map[string]string{ | |||
| metadata.SpiceDBConfigKey: "n549h6bh675h699h697h86h5cchdfq", | |||
| metadata.SpiceDBConfigKey: "n59hb4h5f7h5b7h5dchddh79h67dq", | |||
There was a problem hiding this comment.
Does these keys changing imply that existing operators, when updated, will cause all resources to be re-applied?
There was a problem hiding this comment.
It does, I didn't look into why this happened specifically, but we did jump from 1.26 client go to 1.28 so I assume it's something in the deployment fields.
josephschorr
approved these changes
Aug 18, 2023
| @@ -11,7 +11,7 @@ on: # yamllint disable-line rule:truthy | |||
| branches: | |||
| - "*" | |||
| env: | |||
| GO_VERSION: "~1.19" | |||
| GO_VERSION: "~1.20" | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: authzed/controller-idioms#40 for more details