docs: update sensor calibration documentation #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
6 times, most recently
from
41adae6 to
5695261
Compare
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
7 times, most recently
from
d5b577d to
11d2fe6
Compare
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
4 times, most recently
from
835d213 to
571b5f4
Compare
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
2 times, most recently
from
e79fe12 to
48fb69d
Compare
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
from
48fb69d to
5b31f7d
Compare
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
from
a44e54e to
7adc794
Compare
Signed-off-by: ismetatabay <[email protected]>
|
Hi @mitsudome-r san, also this PR is ready for review, FYI. |
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
from
40ae0fb to
e43c732
Compare
mitsudome-r
reviewed
Oct 6, 2023
...-autoware/creating-vehicle-and-sensor-description/calibrating-sensors/calibrating-sensors.md
Outdated
Show resolved
Hide resolved
...o-guides/integrating-autoware/creating-vehicle-and-sensor-description/calibrating-sensors.md
Outdated
Show resolved
Hide resolved
...-autoware/creating-vehicle-and-sensor-description/calibrating-sensors/calibrating-sensors.md
Outdated
Show resolved
Hide resolved
...g-autoware/creating-vehicle-and-sensor-description/calibrating-sensors/manual-calibration.md
Outdated
Show resolved
Hide resolved
...g-autoware/creating-vehicle-and-sensor-description/calibrating-sensors/manual-calibration.md
Outdated
Show resolved
Hide resolved
...oware/creating-vehicle-and-sensor-description/calibrating-sensors/lidar-lidar-calibration.md
Outdated
Show resolved
Hide resolved
...g-autoware/creating-vehicle-and-sensor-description/calibrating-sensors/manual-calibration.md
Outdated
Show resolved
Hide resolved
...oware/creating-vehicle-and-sensor-description/calibrating-sensors/lidar-lidar-calibration.md
Outdated
Show resolved
Hide resolved
.../creating-vehicle-and-sensor-description/calibrating-sensors/intrinsic-camera-calibration.md
Outdated
Show resolved
Hide resolved
...ware/creating-vehicle-and-sensor-description/calibrating-sensors/lidar-camera-calibration.md
Outdated
Show resolved
Hide resolved
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
2 times, most recently
from
6648c43 to
4fce177
Compare
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
from
4fce177 to
7b3490a
Compare
Signed-off-by: ismetatabay <[email protected]>
|
Hi @mitsudome-r san, thank you for your suggestions. I applied your review comments on documentation, can you check it when you are available? |
Signed-off-by: ismetatabay <[email protected]>
This was referenced Oct 18, 2023
Signed-off-by: ismetatabay <[email protected]>
|
@ismetatabay Thank you for updating the documentation. The instruction generally looks good to me. |
|
Hi @mitsudome-r, that sounds great. We can provide a sample rosbag for the calibration process. I have included to drive link two bag files for ground-lidar calibration and lidar-lidar calibration. Could you check the link? We performed the calibration process with these bags and this calibration tools branch for tutorial_vehicle. |
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
force-pushed
the
ismet/doc/create-sensor-calibration
branch
from
4928de8 to
52aee52
Compare
ismetatabay
added a commit
to leo-drive/autoware-documentation
that referenced
this pull request
Dec 26, 2023
* init manual calibration Signed-off-by: ismetatabay <[email protected]> * fix typo Signed-off-by: ismetatabay <[email protected]> * add pages Signed-off-by: ismetatabay <[email protected]> * init lidar-lidar calibration Signed-off-by: ismetatabay <[email protected]> * start with explaining mapping-based calibrator Signed-off-by: ismetatabay <[email protected]> * update generic_calibration with new video Signed-off-by: ismetatabay <[email protected]> * finalize mapping-based lidar-lidar calibration process Signed-off-by: ismetatabay <[email protected]> * init ground-lidar calibration document Signed-off-by: ismetatabay <[email protected]> * finalize ground-plane calibration Signed-off-by: ismetatabay <[email protected]> * init interactive calibration document Signed-off-by: ismetatabay <[email protected]> * finalize interactive lidar-camera calibration Signed-off-by: ismetatabay <[email protected]> * init intrinsic camera calibration Signed-off-by: ismetatabay <[email protected]> * finalize intrinsic camera calibration Signed-off-by: ismetatabay <[email protected]> * correct some sentences Signed-off-by: ismetatabay <[email protected]> * refactor calibration documentation structure Signed-off-by: ismetatabay <[email protected]> * refactor calibration page structure Signed-off-by: ismetatabay <[email protected]> * some improvements for calibration documentation Signed-off-by: ismetatabay <[email protected]> * update document according to the tester Signed-off-by: ismetatabay <[email protected]> * some readability improvements Signed-off-by: ismetatabay <[email protected]> * fix broken links Signed-off-by: ismetatabay <[email protected]> * solve conflicts Signed-off-by: ismetatabay <[email protected]> --------- Signed-off-by: ismetatabay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds document section for sensor calibration.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.