Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace scenario msg from tier4_planning_msgs to autoware_internal_planning_msgs #10180

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Feb 20, 2025

Description

This is PR for replacing scenario msgs.
As part of moving some planning packages from Autoware Universe to Core, we are replacing tier4_planning_msgs/Scenario with autoware_internal_planning_msgs/Scenario.

Related links

How was this PR tested?

I have tested with planning simulator and made sure that switching between lane driving and parking went correctly.
TIER IV Evaluator link: https://evaluation.ci.tier4.jp/evaluation/reports/e58aeba9-f76d-5ecb-ae94-2dc46a0f1c26?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@mitsudome-r mitsudome-r marked this pull request as draft February 20, 2025 13:48
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 20, 2025
Copy link

github-actions bot commented Feb 20, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r marked this pull request as ready for review February 26, 2025 00:46
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 26, 2025
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.

Project coverage is 26.76%. Comparing base (a11a3ee) to head (5642d4e).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
planning/autoware_scenario_selector/src/node.cpp 37.50% 4 Missing and 6 partials ⚠️
...or/src/remaining_distance_time_calculator_node.cpp 0.00% 2 Missing ⚠️
...lector/include/autoware/scenario_selector/node.hpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10180      +/-   ##
==========================================
- Coverage   26.79%   26.76%   -0.03%     
==========================================
  Files        1395     1404       +9     
  Lines      107936   108085     +149     
  Branches    41545    41599      +54     
==========================================
+ Hits        28918    28934      +16     
- Misses      76141    76275     +134     
+ Partials     2877     2876       -1     
Flag Coverage Δ *Carryforward flag
differential 26.51% <40.90%> (?)
total 26.76% <ø> (-0.03%) ⬇️ Carriedforward from 3fd5f8c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit f0cd1a5 into autowarefoundation:main Feb 26, 2025
44 of 48 checks passed
mitsudome-r added a commit to mitsudome-r/autoware.universe that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants