Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_utils): replace autoware_universe_utils with autoware_utils #10191

Merged
merged 22 commits into from
Feb 26, 2025
Merged

feat(autoware_utils): replace autoware_universe_utils with autoware_utils #10191

merged 22 commits into from
Feb 26, 2025

Conversation

liuXinGangChina
Copy link
Contributor

@liuXinGangChina liuXinGangChina commented Feb 24, 2025 •
edited by mitsudome-r
Loading

Description

replace autoware_universe_utils dependency with autoware_utils for all the packages under universe/planning folder, autoware_utils，what i done:

  1. replace autoware_universe_utils dependency with autoware_utils for all the packages under universe/planning folder
  2. solve build conflict

EDIT(mitsudome-r):
I have also replaced the reset of autoware_unvierse_utils in other folder as well.

Related links

Parent Issue: -- autowarefoundation/autoware.core#192

How was this PR tested?

  1. test with "colcon build ... ..." for all the packages in autoware folder
  2. test with planning simulator with task A-2-B
    Screenshot from 2025-02-24 10-28-02

Notes for reviewers

this pr should be merged with pr-30 under autoware_utils repo

Interface changes

None.

Effects on system behavior

None.

@liuXinGangChina liuXinGangChina added component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 24, 2025
@liuXinGangChina liuXinGangChina self-assigned this Feb 24, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Feb 24, 2025
@liuXinGangChina liuXinGangChina mentioned this pull request Feb 24, 2025
Merged
kosuke55
kosuke55 approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@kosuke55
Copy link
Contributor

kosuke55 commented Feb 24, 2025 •
edited
Loading

run evaluator with autowarefoundation/autoware_utils#30
https://evaluation.tier4.jp/evaluation/reports/b01356bb-afa7-5ec1-a508-e713fb062fd2?project_id=prd_jt

-> 3784/3787 OK!!

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Feb 26, 2025
@mitsudome-r
Copy link
Member

mitsudome-r commented Feb 26, 2025 •
edited by liuXinGangChina
Loading

Waiting for https://evaluation.ci.tier4.jp/evaluation/reports/3dbcccbd-bb17-5fe3-9ab3-fc493033a447?project_id=prd_jt

got it，mits san，i will wait and see if ci raise error

@mitsudome-r mitsudome-r mentioned this pull request Feb 26, 2025
Merged
@mitsudome-r
Copy link
Member

I found that CI in the main branch is failing (which means the CI for this PR is also likely to fail)
This should have fix the error: #10180

@xmfcx xmfcx added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 26, 2025
@mitsudome-r mitsudome-r merged commit ece3809 into autowarefoundation:main Feb 26, 2025
34 of 35 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 26, 2025
Merged
mitsudome-r pushed a commit to mitsudome-r/autoware.universe that referenced this pull request Feb 27, 2025
@liuXinGangChina @mitsudome-r
feat(autoware_utils): replace autoware_universe_utils with autoware_u…
acb2283 
…tils (autowarefoundation#10191)

Signed-off-by: liuXinGangChina <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
This was referenced Feb 27, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosuke55 kosuke55 kosuke55 approved these changes

@danielsanchezaran danielsanchezaran danielsanchezaran approved these changes

@shmpwk shmpwk shmpwk approved these changes

@youtalk youtalk youtalk approved these changes

@soblin soblin soblin approved these changes

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@rej55 rej55 rej55 approved these changes

@yhisaki yhisaki yhisaki approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@technolojin technolojin technolojin approved these changes

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@satoshi-ota satoshi-ota satoshi-ota approved these changes

@maxime-clem maxime-clem maxime-clem approved these changes

@MasatoSaeki MasatoSaeki MasatoSaeki approved these changes

@mkquda mkquda mkquda approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@zusizusi zusizusi Awaiting requested review from zusizusi zusizusi is a code owner

@N-Eiki N-Eiki Awaiting requested review from N-Eiki N-Eiki is a code owner

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi 1222-takeshi is a code owner

@ito-san ito-san Awaiting requested review from ito-san ito-san is a code owner

@sasakisasaki sasakisasaki Awaiting requested review from sasakisasaki sasakisasaki is a code owner

@TetsuKawa TetsuKawa Awaiting requested review from TetsuKawa TetsuKawa is a code owner

@veqcc veqcc Awaiting requested review from veqcc veqcc is a code owner

@HansRobo HansRobo Awaiting requested review from HansRobo HansRobo is a code owner

@xtk8532704 xtk8532704 Awaiting requested review from xtk8532704 xtk8532704 is a code owner

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima is a code owner

@scepter914 scepter914 Awaiting requested review from scepter914 scepter914 is a code owner

@miursh miursh Awaiting requested review from miursh

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen is a code owner

@drwnz drwnz Awaiting requested review from drwnz drwnz is a code owner

@knzo25 knzo25 Awaiting requested review from knzo25 knzo25 is a code owner

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu meliketanrikulu is a code owner

@vividf vividf Awaiting requested review from vividf vividf is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

@tzhong518 tzhong518 Awaiting requested review from tzhong518 tzhong518 is a code owner

@dan-dnn dan-dnn Awaiting requested review from dan-dnn dan-dnn is a code owner

@ktro2828 ktro2828 Awaiting requested review from ktro2828 ktro2828 is a code owner

@manato manato Awaiting requested review from manato manato is a code owner

@kaancolak kaancolak Awaiting requested review from kaancolak kaancolak is a code owner

@amadeuszsz amadeuszsz Awaiting requested review from amadeuszsz amadeuszsz is a code owner

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto Shin-kyoto is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro SakodaShintaro is a code owner

@djargot djargot Awaiting requested review from djargot djargot is a code owner

Assignees

@takayuki5168 takayuki5168

@soblin soblin

@shmpwk shmpwk

@mitsudome-r mitsudome-r

@liuXinGangChina liuXinGangChina

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.