fix(tensorrt_yolox): renamed input output topic names #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ego Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]>
github-actions
bot
added
the
component:perception
|
@miursh thank you for your feedback. I changed |
The input and output argument names of yolox.launch.xml do not match the input and output arguments names of multiple_yolox.launch.xml. Signed-off-by: Ioannis Souflas <[email protected]>
miursh
approved these changes
Feb 26, 2024
miursh
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6472 +/- ##
==========================================
- Coverage 15.20% 15.08% -0.12%
==========================================
Files 1851 1857 +6
Lines 128434 129436 +1002
Branches 39228 39228
==========================================
Hits 19522 19522
- Misses 87122 88124 +1002
Partials 21790 21790
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miursh
added
run:build-and-test-differential
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
* feat(obstacle_cruise_planner): add calculation of obstacle distance to ego Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]> * fix(tensorrt_yolox): renamed input output topic names The input and output argument names of yolox.launch.xml do not match the input and output arguments names of multiple_yolox.launch.xml. Signed-off-by: Ioannis Souflas <[email protected]> --------- Signed-off-by: Ioannis Souflas <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]> Signed-off-by: Kotaro Yoshimoto <[email protected]>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…tion#6472) * feat(obstacle_cruise_planner): add calculation of obstacle distance to ego Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]> * fix(tensorrt_yolox): renamed input output topic names The input and output argument names of yolox.launch.xml do not match the input and output arguments names of multiple_yolox.launch.xml. Signed-off-by: Ioannis Souflas <[email protected]> --------- Signed-off-by: Ioannis Souflas <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]> Signed-off-by: kaigohirao <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…tion#6472) * feat(obstacle_cruise_planner): add calculation of obstacle distance to ego Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <[email protected]> * fix(tensorrt_yolox): renamed input output topic names The input and output argument names of yolox.launch.xml do not match the input and output arguments names of multiple_yolox.launch.xml. Signed-off-by: Ioannis Souflas <[email protected]> --------- Signed-off-by: Ioannis Souflas <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The input and output argument names of
yolox.launch.xmldo not match the input and output arguments names ofmultiple_yolox.launch.xml.Tests performed
Tested mainly using AWSIM. I uncommented the
multiple_yolox.launch.xmllaunch file from thecamera_lidar_detector.launch.xmland noticed that the functionality was not working as expected. After renaming the input (input/image->input_topic) output (output/objects->output_topic) topics I was able to see theyoloxdetections.Effects on system behavior
tensorrt_yoloxfunctionality is now working.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.