Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lidar_centerpoint): remove python3-open3d depend #7758

Merged

Conversation

amadeuszsz
Copy link
Contributor

Description

This is the only <depend>python3-open3d</depend> invocation in autoware.universe. We don't need this dependency anymore.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 30, 2024
Copy link

github-actions bot commented Jun 30, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@amadeuszsz amadeuszsz added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.21%. Comparing base (3d849e9) to head (fe82bbc).
Report is 551 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7758       +/-   ##
==========================================
- Coverage   15.09%   3.21%   -11.88%     
==========================================
  Files        1967     126     -1841     
  Lines      135941    8301   -127640     
  Branches    42122    1411    -40711     
==========================================
- Hits        20520     267    -20253     
+ Misses      92700    7944    -84756     
+ Partials    22721      90    -22631     
Flag Coverage Δ
differential 3.21% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

it seems the guys who deleted the single inference node forgot to delete this dependency

@amadeuszsz amadeuszsz enabled auto-merge (squash) July 1, 2024 06:42
@amadeuszsz amadeuszsz merged commit a19cb27 into autowarefoundation:main Jul 1, 2024
29 of 30 checks passed
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
knzo25 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants