-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lidar_centerpoint): remove python3-open3d depend #7758
fix(lidar_centerpoint): remove python3-open3d depend #7758
Conversation
Signed-off-by: Amadeusz Szymko <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7758 +/- ##
==========================================
- Coverage 15.09% 3.21% -11.88%
==========================================
Files 1967 126 -1841
Lines 135941 8301 -127640
Branches 42122 1411 -40711
==========================================
- Hits 20520 267 -20253
+ Misses 92700 7944 -84756
+ Partials 22721 90 -22631
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it seems the guys who deleted the single inference node forgot to delete this dependency
…ion#7758) Signed-off-by: Amadeusz Szymko <[email protected]>
…ion#7758) Signed-off-by: Amadeusz Szymko <[email protected]> Signed-off-by: palas21 <[email protected]>
…ion#7758) Signed-off-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
…ion#7758) Signed-off-by: Amadeusz Szymko <[email protected]>
Description
This is the only
<depend>python3-open3d</depend>
invocation in autoware.universe. We don't need this dependency anymore.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.