-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_dummy_diag_publisher): add autowre prefix #9958
base: main
Are you sure you want to change the base?
fix(autoware_dummy_diag_publisher): add autowre prefix #9958
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9958 +/- ##
==========================================
- Coverage 29.45% 29.43% -0.03%
==========================================
Files 1425 1427 +2
Lines 107854 107954 +100
Branches 42822 42839 +17
==========================================
Hits 31772 31772
- Misses 73018 73118 +100
Partials 3064 3064
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: TetsuKawa <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
29a7f30
to
8581431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick Comment
Looks good.
Reason for Approval
The changed files looks contains all the necessary fixes and it is also tested by ros2 launch
. Thus, this PR is merge-able 👍
Description
This PR changes package name to atuoware_dummy_diag_publisher
Related links
Private Links:
these PR is necessary to be merged with this PR.
How was this PR tested?
ros2 launch autoware_dummy_diag_publisher dummy_diag_publisher.launch.xml
$ ros2 param set /dummy_diag_publisher dummy_diag_empty.is_active true
orfalse
$ ros2 param set /dummy_diag_publisher dummy_diag_empty.status "Error"
,Warn
,OK
Screencast.from.2025.01.18.15.37.41.webm
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
Effects on launch file that run dummy_diag_publisher.
It looks like only in tier4_system_launch. #9959