-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply autoware_
prefix for hazard_status_converter
#9971
base: main
Are you sure you want to change the base?
feat: apply autoware_
prefix for hazard_status_converter
#9971
Conversation
Signed-off-by: Junya Sasaki <[email protected]>
Signed-off-by: Junya Sasaki <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9971 +/- ##
==========================================
- Coverage 29.43% 29.41% -0.02%
==========================================
Files 1425 1426 +1
Lines 107854 107906 +52
Branches 42822 42842 +20
==========================================
Hits 31745 31745
- Misses 73048 73100 +52
Partials 3061 3061
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -1,4 +1,4 @@ | |||
// Copyright 2023 The Autoware Contributors | |||
// Copyright 2025 The Autoware Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the copyright year. This is the publication year.
@@ -1,4 +1,4 @@ | |||
// Copyright 2023 The Autoware Contributors | |||
// Copyright 2025 The Autoware Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the copyright year. This is the publication year.
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_
prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.Related Links
How was this PR tested?
Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Directory Name
autoware_
as a prefix to the directory name.packages.xml
autoware_
to thename
element.CMakeLists.txt
project
name toautoware_***
.autoware::
toPLUGIN
.Header Files (.hpp)
#ifndef
guards withAUTOWARE__
.autoware::
tonamespace
.Source Files (.cpp)
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.Launch Files
autoware_
beforefind-pkg-share
.node pkg="<pkgname>"
toautoware_<pkgname>
.Include
autoware
folder as necessary and update include statements accordingly.Verification Points
find-pkg-share
in autowaresensor_launch
as seen ingnss_poser
Notes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
hazard_status_converter
needs to modify their code. This is maybe kind of non quick-win task.