Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply autoware_ prefix for hazard_status_converter #9971

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: apply autoware_ prefix for hazard_status_converter #9971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4a3e1e
feat(hazard_status_converter): apply `autoware_` prefix
sasakisasaki Jan 19, 2025
5a88be8
rename: `hazard_status_converter` => `autoware_hazard_status_converter`
sasakisasaki Jan 19, 2025
4d02451
style(pre-commit): autofix
pre-commit-ci[bot] Jan 19, 2025
5c8f560
Merge branch 'main' into feat-apply-autoware-prefix-for-system-hazard…
sasakisasaki Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 system/hazard_status_converter/CHANGELOG.rst → ...are_hazard_status_converter/CHANGELOG.rst
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...em/hazard_status_converter/CMakeLists.txt → ...re_hazard_status_converter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.14)
project(hazard_status_converter)
project(autoware_hazard_status_converter)

find_package(autoware_cmake REQUIRED)
autoware_package()
Expand All @@ -9,8 +9,8 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
)

rclcpp_components_register_node(${PROJECT_NAME}
PLUGIN "hazard_status_converter::Converter"
EXECUTABLE converter
PLUGIN "autoware::hazard_status_converter::Converter"
EXECUTABLE ${PROJECT_NAME}_node
)

ament_auto_package(INSTALL_TO_SHARE launch)
2 changes: 1 addition & 1 deletion ...launch/hazard_status_converter.launch.xml → ...launch/hazard_status_converter.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<launch>
<node pkg="hazard_status_converter" exec="converter" name="hazard_status_converter">
<node pkg="autoware_hazard_status_converter" exec="autoware_hazard_status_converter_node" name="hazard_status_converter">
<remap from="~/diagnostics_graph" to="/diagnostics_graph"/>
<remap from="~/hazard_status" to="/system/emergency/hazard_status"/>
<remap from="~/input/emergency_holding" to="/system/emergency_holding"/>
Expand Down
3 changes: 2 additions & 1 deletion system/hazard_status_converter/package.xml → ...oware_hazard_status_converter/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>hazard_status_converter</name>
<name>autoware_hazard_status_converter</name>
<version>0.40.0</version>
<description>The hazard_status_converter package</description>
<maintainer email="[email protected]">Takagi, Isamu</maintainer>
<maintainer email="[email protected]">Junya Sasaki</maintainer>
<license>Apache License 2.0</license>

<buildtool_depend>ament_cmake_auto</buildtool_depend>
Expand Down
8 changes: 4 additions & 4 deletions ...hazard_status_converter/src/converter.cpp → ...hazard_status_converter/src/converter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2023 The Autoware Contributors
// Copyright 2025 The Autoware Contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the copyright year. This is the publication year.

//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -18,7 +18,7 @@
#include <utility>
#include <vector>

namespace hazard_status_converter
namespace autoware::hazard_status_converter
{

Converter::Converter(const rclcpp::NodeOptions & options) : Node("converter", options)
Expand Down Expand Up @@ -125,7 +125,7 @@
pub_hazard_->publish(hazard);
}

} // namespace hazard_status_converter
} // namespace autoware::hazard_status_converter

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(hazard_status_converter::Converter)
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::hazard_status_converter::Converter)

Check warning on line 131 in system/autoware_hazard_status_converter/src/converter.cpp

View check run for this annotation

Codecov / codecov/patch

system/autoware_hazard_status_converter/src/converter.cpp#L131 

Added line #L131 was not covered by tests
6 changes: 3 additions & 3 deletions ...hazard_status_converter/src/converter.hpp → ...hazard_status_converter/src/converter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2023 The Autoware Contributors
// Copyright 2025 The Autoware Contributors
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the copyright year. This is the publication year.

// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -24,7 +24,7 @@

#include <unordered_set>

namespace hazard_status_converter
namespace autoware::hazard_status_converter
{

class Converter : public rclcpp::Node
Expand All @@ -48,6 +48,6 @@ class Converter : public rclcpp::Node
std::unordered_set<DiagUnit *> auto_mode_tree_;
};

} // namespace hazard_status_converter
} // namespace autoware::hazard_status_converter

#endif // CONVERTER_HPP_
Loading