Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(traffic_light): rename enable_fine_detection #1310

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jan 23, 2025

Description

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 23, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shmpwk
shmpwk previously approved these changes Jan 27, 2025
@shmpwk shmpwk dismissed their stale review January 27, 2025 00:23

need to check more

@shmpwk
Copy link
Contributor

shmpwk commented Jan 27, 2025

@badai-nguyen This PR includes diag commits. Are they intended?

@badai-nguyen
Copy link
Contributor Author

badai-nguyen commented Jan 27, 2025

@shmpwk I made a typo when I rebased/update another branch. The intial version of commit only contained the minimum change without old commits. let me rebase it again. Sorry for that.

@badai-nguyen
Copy link
Contributor Author

@shmpwk
I fixed my rebase mistake.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants