Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get bitcoin history from vm module #7

Merged
merged 6 commits into from
Aug 13, 2024
Merged

refactor: get bitcoin history from vm module #7

merged 6 commits into from
Aug 13, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Jul 31, 2024 •
edited
Loading

Description

TODO

  • Release fixed BitcoinModule and update versions in package.json

Changes

  • Fetches BTC history using the BitcoinModule

Testing

  • Verify you can see the activity screen correctly for Bitcoin

Screenshots

No visual changes
image

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w mentioned this pull request Jul 31, 2024
Merged
3 tasks
@meeh0w meeh0w force-pushed the refactor/btc-history branch from 122454a to dad3218 Compare July 31, 2024 13:21
@meeh0w meeh0w force-pushed the refactor/btc-history branch from dad3218 to a335e12 Compare August 2, 2024 10:07
@meeh0w meeh0w mentioned this pull request Aug 2, 2024
Merged
2 tasks
vvava
vvava previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo

gergelylovas
gergelylovas previously approved these changes Aug 13, 2024
View reviewed changes
@gergelylovas gergelylovas dismissed stale reviews from vvava and themself via eaee348 August 13, 2024 17:23
@gergelylovas gergelylovas merged commit 243e747 into main Aug 13, 2024
4 of 5 checks passed
@gergelylovas gergelylovas deleted the refactor/btc-history branch August 13, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvava vvava vvava approved these changes

@gergelylovas gergelylovas gergelylovas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeh0w @gergelylovas @vvava