Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting for key value fields #3299

Merged
merged 13 commits into from
Nov 1, 2024

Conversation

enderahmetyurt
Copy link
Contributor

@enderahmetyurt enderahmetyurt commented Oct 2, 2024

Description

Adding up and down button to sort key-value fields.

Fixes #1029

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Screen.Recording.2024-10-02.at.16.14.27.mov

Copy link

codeclimate bot commented Oct 2, 2024

Code Climate has analyzed commit 53c4d23 and detected 0 issues on this pull request.

View more on Code Climate.

@enderahmetyurt
Copy link
Contributor Author

@adrianthedev @Paul-Bob it should be ready :)

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thank you @enderahmetyurt for this contribution!

@adrianthedev
Copy link
Collaborator

This is great @enderahmetyurt! Awesoem work!

There's only one thing I'd like to do more.
Move the arrows to the right side and make them blend in. Make them look like the trash icon (or even smaller if they look nice).

Thanks for working on this.

@enderahmetyurt
Copy link
Contributor Author

good idea thanks @adrianthedev. Wdty?
Screenshot 2024-10-07 at 16 38 03

@enderahmetyurt
Copy link
Contributor Author

enderahmetyurt commented Oct 15, 2024

@adrianthedev @Paul-Bob I added enderahmetyurt#1 solution to here. wdyt?

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better with the DnD! Thank you for your effort on this @enderahmetyurt!

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your effort on this contribution @enderahmetyurt. It turned out great!

I fixed a bug in the drag-and-drop logic that was swapping elements instead of inserting the dragged element in the intended drop location.

Additionally, I added localization support for the reorder title and refactored the label getters.

@Paul-Bob
Copy link
Contributor

Paul-Bob commented Nov 1, 2024

@enderahmetyurt could you please update de description since the text and video are outdated?

Thank you!

@Paul-Bob Paul-Bob merged commit 08269fc into avo-hq:main Nov 1, 2024
21 of 22 checks passed
@enderahmetyurt
Copy link
Contributor Author

@enderahmetyurt could you please update de description since the text and video are outdated?

Thank you!

Thank you very much @Paul-Bob I'll update the description of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder key-value fields
3 participants