Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dnd #1

Conversation

adrianthedev
Copy link

I wasn't able to make the arrow buttons pretty and compact, so I added drag and drop.
Can you see if it works nicely on your end and then merge it to your PR?

@adrianthedev
Copy link
Author

Please hold off merging a little bit. I found a bug.

@adrianthedev
Copy link
Author

@enderahmetyurt The sorting algo isn't working properly sometimes.
I can't have a look right now. Would you be able to check that out?

CleanShot.2024-10-11.at.14.24.58.mp4

@enderahmetyurt
Copy link
Owner

Hey @adrianthedev thank you. I will look at it

@enderahmetyurt
Copy link
Owner

it looks fine @adrianthedev

@enderahmetyurt enderahmetyurt merged commit 7d2b5c5 into enderahmetyurt:feature/reorder-key-value-fields Oct 15, 2024
@adrianthedev
Copy link
Author

In the video you can see that the drag and drop work to switch places (when we drag the one under the four, it takes the four in the place of the one instead of just placing the one below the four) instead of regular drag and drop where you reorder items.

So the intended result should have been "two, three, four one", but now it's "four, two, three, one".

@enderahmetyurt
Copy link
Owner

hmm I missed it. I can control and try to fix it here avo-hq#3299 or I can get back it

@adrianthedev
Copy link
Author

Yeah, it's fine to fix it there. I couldn't push to that branch, that's why I made this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants