Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.ja #267

Merged
merged 10 commits into from
Jul 3, 2024
Merged

main.ja #267

merged 10 commits into from
Jul 3, 2024

Conversation

cmick-aws
Copy link
Contributor

What does this PR do and why?

  • Populated English version fixes to Japanese localization.
  • Fixed absolute URL in English version to point to relative path in same build.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cmick-aws cmick-aws requested a review from rezabekf July 2, 2024 03:56
@cmick-aws cmick-aws requested a review from a team as a code owner July 2, 2024 03:56
Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@rezabekf rezabekf merged commit ad9f335 into main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants