Jitter Entropy 3.6.1 CI test #2220
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torben-hansen
force-pushed
the
import_jitter_entropy_3_6_1
branch
from
a404e03 to
7ba2b75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## randomness_generation #2220 +/- ##
=========================================================
- Coverage 79.04% 79.02% -0.02%
=========================================================
Files 628 628
Lines 107205 107243 +38
Branches 15152 15168 +16
=========================================================
+ Hits 84736 84748 +12
- Misses 21752 21775 +23
- Partials 717 720 +3 ☔ View full report in Codecov by Sentry. |
torben-hansen
added a commit
to aws/aws-lc-rs
that referenced
this pull request
Mar 3, 2025
aws/aws-lc#2220 introduces a new method to import Jitter Entropy and previous PRs added Jitter Entropy for all build types. This didn't quite work with aws-lc-rs build that only expected Jitter Entropy for some select FIPS builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.