Bump version to 0.5.0 and fix clippy #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update rust-toolchain: 1.74.0 * fix clippy: remove unnecessary cast fix clippy: remove unnecessary cast * fix clippy: remove unnecesarry ref * fix clippy: allow redundant closure call * fix clippy: introduce iterators when possible fix clippy: introduce iterators when possible * fix clippy: tuple inicialization * fix clippy: motgomery_form behind asm feature * fix clippy: move use ::serde
jonathanpwang
changed the title
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with upstream for v0.5.0.
See privacy-scaling-explorations#96 for context.
Highlight
Emphasize that now the
Serialize, Deserializeimplementations forbn256::{Fr, G1Affine}are using the human-readable (akato_repr()implementations) format. One should remember that this means you should NOT useSerialize, Deserializeimplementations for anything where performance is critical (such as serializing/deserializing proving keys).Currently we use
bincodewith the derivedSerialize, DeserializeonSnark, but since snark proofs are pretty small it should be inconsequential.