Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove return types from Save #2063

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • This was causing the CreateAllocationAgreementSchema validation to run despite the types being defined as a union. AFAIK Flask does not like union types on views.

@dhaselhan dhaselhan requested a review from AlexZorkin February 21, 2025 00:45
@dhaselhan dhaselhan force-pushed the fix/daniel-delete-allocaion-2046 branch from 75d13d2 to 6acd764 Compare February 21, 2025 00:47
* This was causing the CreateAllocationAgreementSchema validation to run despite the types being defined as a union. AFAIK Flask does not like union types on views.
@dhaselhan dhaselhan force-pushed the fix/daniel-delete-allocaion-2046 branch from 6acd764 to a74a451 Compare February 21, 2025 00:48
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

github-actions bot commented Feb 21, 2025

Frontend Test Results

  1 files  ±0  130 suites  ±0   48s ⏱️ -2s
448 tests ±0  428 ✅ ±0  20 💤 ±0  0 ❌ ±0 
450 runs  ±0  430 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 7cf77d6. ± Comparison against base commit 9b6e3de.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 21, 2025

Backend Test Results

590 tests  ±0   590 ✅ ±0   2m 44s ⏱️ +2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7cf77d6. ± Comparison against base commit 9b6e3de.

♻️ This comment has been updated with latest results.

@dhaselhan dhaselhan merged commit 55110bf into release-1.0.0 Feb 21, 2025
5 checks passed
@dhaselhan dhaselhan deleted the fix/daniel-delete-allocaion-2046 branch February 21, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants