Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: remove bento base image #22

Merged
merged 5 commits into from
Feb 7, 2025
Merged

refact: remove bento base image #22

merged 5 commits into from
Feb 7, 2025

Conversation

v-rocheleau
Copy link
Contributor

Removes the Bento base image, while keeping a non-root user whose name, UID and GID can be provided when running the container.
The Dockerfile entrypoint handles the non-root user creation, simply provide these environment variables:

  • TDS_USER : username that will run the service
  • TDS_UID: Numeric user ID of TDS_USER (defaults to 1000)
  • TDS_GID: Numeric group ID (defaults to TDS_UID)

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (378ca3e) to head (d98718f).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          14       14           
  Lines         576      576           
  Branches       29       29           
=======================================
  Hits          468      468           
  Misses         97       97           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@noctillion noctillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@v-rocheleau v-rocheleau merged commit 1c26941 into main Feb 7, 2025
7 checks passed
@v-rocheleau v-rocheleau deleted the refact/base-img branch February 7, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on Bento specific Debian image
2 participants