-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: remove bento_lib coupling for config and server #25
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 81.39% 81.52% +0.12%
==========================================
Files 14 14
Lines 586 628 +42
Branches 30 32 +2
==========================================
+ Hits 477 512 +35
- Misses 98 103 +5
- Partials 11 13 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, what is the reason for adding duplicate code back in beyond funny BENTO_
prefixes of env vars?
Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR removes the usage of
bento_lib
to initialize the FastAPI app and Pydantic Settings.The aim is to remove user-facing concepts that are specific to Bento, like environment variables prefixes, and service-info extensions.
These changes also allow adopters to use their own GA4GH service-info definitions.
Also includes a refactor that removes the ingestion router, since the ingestion is done from the experiment path.