WIP: Added amomin, amomax, amominu, amomaxu to Core & Caches #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought I needed these for nbody, and did not. Work in progress because these are not tested or validated. Perhaps someone can build off of my work
tommydcjung
reviewed
Jan 6, 2022
| @@ -157,7 +157,7 @@ module bsg_manycore_link_to_cache | |||
| e_cache_op: begin | |||
| return_pkt_type = e_return_credit; | |||
| end | |||
| e_remote_amoswap, e_remote_amoor, e_remote_amoadd: begin | |||
| e_remote_amoswap, e_remote_amoor, e_remote_amoadd, e_remote_amomin, e_remote_amomax, e_remote_amominu, e_remote_amomaxu: begin | |||
There was a problem hiding this comment.
You also need to assign opcode in the case statement starting at line 285
|
These seem useful! M |
|
I agree, but I don't have an immediate use case (though I have an idea for how this might help the MCS lock). Do you want me to push it through? Happy to address the comment above and write a few test cases |
|
Looks interesting, needs some tests too |
|
Yep. I just addressed Tommy's comment while I had a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I needed these for nbody, and did not. Work in progress
because these are not tested or validated. Perhaps someone can build
off of my work
WIP and DNM until someone needs them.