Enrollments#update no longer works with migrated target API

betagouv · May 21, 2024 · 0a83797 · 0a83797
1 parent 30b7aaa
commit 0a83797
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/backend/app/policies/enrollment_policy.rb b/backend/app/policies/enrollment_policy.rb
@@ -19,7 +19,8 @@ def create?
   end
 
   def update?
-    (record.status_draft? || record.status_changes_requested?) &&
+    record.class.migrated_target_apis.exclude?(record.target_api) &&
+      (record.status_draft? || record.status_changes_requested?) &&
       user.belongs_to_organization?(record) &&
       user.is_demandeur?(record)
   end

diff --git a/backend/spec/controllers/enrollments/update_spec.rb b/backend/spec/controllers/enrollments/update_spec.rb
@@ -114,5 +114,12 @@
         }.to change { api_r2p_enrollment.reload.additional_content }.to(api_r2p_attributes[:additional_content].transform_keys(&:to_s))
       end
     end
+
+    context "when updating migrated target api" do
+      let(:target_enrollment) { create(:enrollment, :api_entreprise, user: enrollment_creator) }
+      let(:target_enrollment_attributes) { {} }
+
+      it { is_expected.to have_http_status(:forbidden) }
+    end
   end
 end