Add entity disabling example #17710
Add entity disabling example #17710
Conversation
alice-i-cecile
added
A-ECS
|
The generated |
examples/ecs/entity_disabling.rs
Outdated
| // Just add the `Disabled` component to the entity to disable it. | ||
| // Note that the `Disabled` component is *only* added to the entity, | ||
| // its children are not affected. | ||
| commands.entity(clicked_entity).insert(Disabled); |
There was a problem hiding this comment.
That's interesting! Since the entity is disabled, does that cause the parent/child relationship to break, orphaning those children? Or does the relationship stick around and the children just have a disabled parent?
There was a problem hiding this comment.
The latter :) I don't think much of our code is robust to it yet though!
examples/ecs/entity_disabling.rs
Outdated
|
|
||
| fn disable_entities_on_click( | ||
| trigger: Trigger<Pointer<Click>>, | ||
| ignored_query: Query<(), Or<(With<Window>, With<Text>)>>, |
There was a problem hiding this comment.
This query is super fascinating to me cause you are querying for 'Void' with some stuff on it. I know that's not the point of this example, but what's the difference between this and just querying for all entities with those components and then doing an equality check on the entities below?
There was a problem hiding this comment.
This will avoid actually fetching / locking the data :) We don't actually care about the data contained inside!
Co-authored-by: Zachary Harrold <[email protected]>
alice-i-cecile
removed
the
S-Needs-Review
alice-i-cecile
added
the
S-Ready-For-Final-Review
# Objective The entity disabling / default query filter work added in bevyengine#17514 and bevyengine#13120 is neat, but we don't teach users how it works! We should fix that before 0.16. ## Solution Write a simple example to teach the basics of entity disabling! ## Testing `cargo run --example entity_disabling` ## Showcase  --------- Co-authored-by: Zachary Harrold <[email protected]>
Objective
The entity disabling / default query filter work added in #17514 and #13120 is neat, but we don't teach users how it works!
We should fix that before 0.16.
Solution
Write a simple example to teach the basics of entity disabling!
Testing
cargo run --example entity_disablingShowcase