Replace some !Send resources with thread_local!
#17730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0319455.
joshua-holmes
force-pushed
the
thread-local
branch
from
b0e821c to
38ffe2c
Compare
joshua-holmes
force-pushed
the
thread-local
branch
from
1a9c211 to
789a9bf
Compare
alice-i-cecile
added
C-Feature
joshua-holmes
force-pushed
the
thread-local
branch
from
789a9bf to
df85779
Compare
|
Won't this cause multiple worlds to share the same |
|
Yes, in theory multiple worlds could share these resources. However, in practice in this PR, that is not happening. Keep in mind, I am not changing the API in any way. I am only changing how a few internal variables are stored. |
|
@alice-i-cecile, just pinging you here for review on GitHub as well, in case that's your preferred workflow |
chescock
reviewed
Feb 21, 2025
joshua-holmes
changed the title
!Send resources with thread_local!!Send resources with thread_local!
alice-i-cecile
added
S-Needs-Review
joshua-holmes
force-pushed
the
thread-local
branch
from
751410f to
a114044
Compare
joshua-holmes
force-pushed
the
thread-local
branch
from
a114044 to
c62693c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Work for issue #17682
What's in this PR:
!Sendresources that Bevy uses internally!Sendresources withthread_local!staticWhat this PR does not cover:
!Sendresources still exists!Sendresources are present (and should not be removed until the ability to create!Sendresources is removed)log_layers_ecsstill uses a!Sendresource. In this example, removing the!Sendresource results in the system that uses it running on a thread other than the main thread, which doesn't work with lazily initializedthread_local!static data. Removing this!Sendresource will need to be deferred until the System API is extended to support configuring which thread the System runs on. Once an issue for this work is created, it will be mentioned in 🐢 Eliminate!Sendresources by supportingSendand!SendWorldin the same binary #17667Once the System API is extended to allow control of which thread the System runs on, the rest of the
!Sendresources can be removed in a different PR.