-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uv_transform
to ColorMaterial
#17879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward change and a reasonable feature. Not keen on the example explosion, but it's helpful for testing and learning.
i usually make an example after seeing it crop up in the help channel a couple times, then having something to just link to them is nice maybe not include as a wasm example would be nice though |
this one specifically could also just be merged into the already existing |
This is my longterm preference, but because of the way the screenshot tool is currently setup I like having it split out as a test for now. (cc @mockersf) |
one thing that i did not test was seeing if wasm would complain about alignment, does ci test that? |
one thing that i could add is |
I like that :) |
should i also move the example to the |
…pha_mode` example
…_repeated_texture` example
Objective
Implements and closes #17515
Solution
Add
uv_transform
toColorMaterial
Testing
Create a example similar to
repeated_texture
but forMesh2d
andMeshMaterial2d<ColorMaterial>
Showcase
Migration Guide
Add
uv_transform
field to constructors ofColorMaterial