Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uv_transform to ColorMaterial #17879

Merged
merged 11 commits into from
Feb 24, 2025
Merged

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented Feb 16, 2025

Objective

Implements and closes #17515

Solution

Add uv_transform to ColorMaterial

Testing

Create a example similar to repeated_texture but for Mesh2d and MeshMaterial2d<ColorMaterial>

Showcase

image

Migration Guide

Add uv_transform field to constructors of ColorMaterial

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use C-Feature A new feature, making something new possible X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 16, 2025
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change and a reasonable feature. Not keen on the example explosion, but it's helpful for testing and learning.

@hukasu
Copy link
Contributor Author

hukasu commented Feb 16, 2025

i usually make an example after seeing it crop up in the help channel a couple times, then having something to just link to them is nice

maybe not include as a wasm example would be nice though

@hukasu
Copy link
Contributor Author

hukasu commented Feb 16, 2025

this one specifically could also just be merged into the already existing repeating_texture example, with a toggle to change between 2d and 3d

@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Feb 16, 2025
@alice-i-cecile
Copy link
Member

this one specifically could also just be merged into the already existing repeating_texture example, with a toggle to change between 2d and 3d

This is my longterm preference, but because of the way the screenshot tool is currently setup I like having it split out as a test for now. (cc @mockersf)

@hukasu
Copy link
Contributor Author

hukasu commented Feb 16, 2025

one thing that i did not test was seeing if wasm would complain about alignment, does ci test that?

@hukasu
Copy link
Contributor Author

hukasu commented Feb 17, 2025

one thing that i could add is Text2ds on top of each rectangle with a small description like Repeat On Control Repeat Off

@alice-i-cecile
Copy link
Member

one thing that i could add is Text2ds on top of each rectangle with a small description like Repeat On Control Repeat Off

I like that :)

@hukasu
Copy link
Contributor Author

hukasu commented Feb 17, 2025

should i also move the example to the asset folder (within examples) or on 2d is fine? name of the file is also ok?

@hukasu
Copy link
Contributor Author

hukasu commented Feb 17, 2025

image
is the font size ok?

@IceSentry IceSentry added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 18, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 24, 2025
Merged via the queue into bevyengine:main with commit 7d7c43d Feb 24, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add uv_transform to ColorMaterial
4 participants