Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dds feature enabling bevy_gltf #17888

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

rparrett
Copy link
Contributor

Objective

Fixes #17022

Solution

Only enable bevy_gltf/dds if bevy_gltf is already enabled.

Testing

Tested with empty project

[dependencies]
bevy = { version = "0.16.0-dev", path = "../bevy", default-features = false, features = [
    "dds",
] }

Before

 cargo tree --depth 1 -i bevy_gltf
bevy_gltf v0.16.0-dev (/Users/robparrett/src/bevy/crates/bevy_gltf)
└── bevy_internal v0.16.0-dev (/Users/robparrett/src/bevy/crates/bevy_internal)

After

 cargo tree --depth 1 -i bevy_gltf
warning: nothing to print.

To find dependencies that require specific target platforms, try to use option `--target all` first, and then narrow your search scope accordingly.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-glTF Related to the glTF 3D scene/model format P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 17, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 17, 2025
Merged via the queue into bevyengine:main with commit 4045b91 Feb 17, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-glTF Related to the glTF 3D scene/model format C-Bug An unexpected or incorrect behavior P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling DDS feature leds to GLTF also becoming enabled
2 participants