Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed toastId returning undefined when using Toastr.error #2181

Merged
merged 1 commit into from
May 7, 2024

Conversation

josephmathew900
Copy link
Contributor

@josephmathew900 josephmathew900 commented May 7, 2024

Description

  • Fixed: toastId returning undefined when using Toastr.error

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2181 May 7, 2024 09:43 Inactive
@josephmathew900 josephmathew900 force-pushed the 2180-fixed-toastId-issue-with-error-toastr branch from 56a8411 to 7aceb6e Compare May 7, 2024 09:51
@josephmathew900 josephmathew900 added the patch Releases small requests or bug fixes. label May 7, 2024
@josephmathew900 josephmathew900 merged commit 6799863 into main May 7, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2180-fixed-toastId-issue-with-error-toastr branch May 7, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toastId is coming undefined for Toastr.error
1 participant