Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more types genomics #176

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

Oddant1
Copy link
Contributor

@Oddant1 Oddant1 commented Feb 13, 2024

Change types_genomics to types in accordance with qiime2/q2-types#309

Blocked by qiime2/q2-types#309

Copy link
Collaborator

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good here - will test locally before merging the blocking types PR and then CI can be re-run here for a final check.

@lizgehret
Copy link
Collaborator

Hey @nbokulich @gregcaporaso could one of you give me write access to this repo? I need to push up some lint fixes and re-run CI before getting this merged (Anthony is officially out for the next week on vacation).

@nbokulich
Copy link
Collaborator

Hi @lizgehret done! thanks @Oddant1 and @lizgehret for making these changes!

@nbokulich
Copy link
Collaborator

Merging this to resolve the chicken-vs-egg problem re: metapackage build. See bokulich-lab/q2-assembly#71 (comment)

@nbokulich nbokulich merged commit bbed7fe into bokulich-lab:master Feb 15, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants