Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Added CI and switched from setup.py to pyproject.toml #5

Merged
merged 15 commits into from
Jan 14, 2025
Merged

MAINT: Added CI and switched from setup.py to pyproject.toml #5

merged 15 commits into from
Jan 14, 2025

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Nov 27, 2024 •
edited
Loading

closes #3

  • Added CI copied from q2-moshpit
  • Changed over from setup.py to pyproject.toml

@VinzentRisch VinzentRisch requested a review from misialq January 9, 2025 16:15
@VinzentRisch
Copy link
Collaborator Author

Hey Michal
I added all the CI checks and an additional black workflow.
I also changed all files like in moshpit to work with the new pyproject.toml.
I added a fake test so the CI will pass.

@VinzentRisch VinzentRisch changed the title CI: Added CI MAINT: Added CI and switched from setup.py to pyproject.toml Jan 9, 2025
@VinzentRisch VinzentRisch mentioned this pull request Jan 10, 2025
Merged
misialq
misialq approved these changes Jan 14, 2025
View reviewed changes
Copy link

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@VinzentRisch VinzentRisch merged commit 8357be4 into bokulich-lab:main Jan 14, 2025
6 checks passed
@VinzentRisch VinzentRisch mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misialq misialq misialq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAINT: Switch from setup.py to pyproject.toml and add CI
2 participants
@VinzentRisch @misialq