Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Titles and Labels #803

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Adjust Titles and Labels #803

merged 1 commit into from
Nov 29, 2023

Conversation

philippfromme
Copy link
Contributor

Closes #801

@barmac
Copy link
Member

barmac commented Nov 28, 2023

For this one, we want to follow bpmn-js pattern, don't we?

@philippfromme philippfromme force-pushed the labels branch 2 times, most recently from 44c21b1 to bcab6e3 Compare November 28, 2023 15:58
@philippfromme
Copy link
Contributor Author

For this one, we want to follow bpmn-js pattern, don't we?

What do you mean?

@barmac
Copy link
Member

barmac commented Nov 29, 2023

We decided to only update labels, so it's not relevant anymore.

@barmac barmac merged commit 8133826 into develop Nov 29, 2023
8 checks passed
@barmac barmac deleted the labels branch November 29, 2023 07:29
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 29, 2023
@nikku
Copy link
Member

nikku commented Nov 29, 2023

Let's consider to mark this as a feature + breaking change as a follow-up, cf. bpmn-io/bpmn-js#2031 (review).

@barmac
Copy link
Member

barmac commented Nov 29, 2023

I rewrote the commit: 1fdb09a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust Lables and Titles
3 participants