Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run Travis tests for plugins either added or modified by PR #36

Merged
merged 49 commits into from
Aug 10, 2023

Conversation

kvfairchild
Copy link
Contributor

@kvfairchild kvfairchild commented Jun 22, 2023

In the interest of reducing blocking test time for Brain-Score domain repositories (especially language), this moves from running all tests on Travis for every plugin on every PR to only running tests for plugins added or modified by the PR on Travis.

The gap in test coverage introduced by this PR is intended to be closed by instead having each PR initiate a non-blocking Jenkins run for all plugin and integration tests (possibly in conjunction with BSL issue #172).

Note: parse_plugin_changes.py will replace parse_changed_files.py in BSL.

Copy link
Member

@mschrimpf mschrimpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find code more maintainable when writing to dicts is centralized and methods don't have to worry about a master-dict, sending some suggestions along these lines. Also added some pydoc

@kvfairchild kvfairchild requested a review from mschrimpf June 29, 2023 16:46
Copy link
Member

@mschrimpf mschrimpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some suggestions to make the code more general

@mschrimpf
Copy link
Member

let's also add marker documentation here if we end up going with those

Katherine Fairchild and others added 6 commits August 4, 2023 10:06
Copy link
Member

@mschrimpf mschrimpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😐

@kvfairchild kvfairchild merged commit 546d8b0 into main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only run travis tests for plugins when first added
3 participants