-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run Travis tests for plugins either added or modified by PR #36
Conversation
…educe-language-test-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find code more maintainable when writing to dicts is centralized and methods don't have to worry about a master-dict, sending some suggestions along these lines. Also added some pydoc
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some suggestions to make the code more general
...anagement/test_parse_plugin_changes__brainscore_dummy/benchmarks/dummy_benchmark/__init__.py
Outdated
Show resolved
Hide resolved
...plugin_management/test_parse_plugin_changes__brainscore_dummy/models/dummy_model/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
Co-authored-by: Martin Schrimpf <[email protected]>
…core_dummy/benchmarks/dummy_benchmark/__init__.py Co-authored-by: Martin Schrimpf <[email protected]>
…core_dummy/models/dummy_model/__init__.py Co-authored-by: Martin Schrimpf <[email protected]>
...anagement/test_parse_plugin_changes__brainscore_dummy/benchmarks/dummy_benchmark/__init__.py
Outdated
Show resolved
Hide resolved
…core_dummy/benchmarks/dummy_benchmark/__init__.py
Co-authored-by: Martin Schrimpf <[email protected]>
let's also add marker documentation here if we end up going with those |
* YAML changes * YAML changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😐
…ain-score/core into kvf/reduce-language-test-time
In the interest of reducing blocking test time for Brain-Score domain repositories (especially language), this moves from running all tests on Travis for every plugin on every PR to only running tests for plugins added or modified by the PR on Travis.
The gap in test coverage introduced by this PR is intended to be closed by instead having each PR initiate a non-blocking Jenkins run for all plugin and integration tests (possibly in conjunction with BSL issue #172).
Note:
parse_plugin_changes.py
will replaceparse_changed_files.py
in BSL.