Migrate to flatlist

[kesha-antonov]

No description provided.

[theneva]

Hi! I've sent a PR to the fork that should make the build pass (kesha-antonov#1). It:

• Fixes the linting errors
• Downgrades React to ~15.5.4 (which is still an upgrade from 15.4.0-rc.4)
• Makes the keyExtractor prop optional, as it's also okay to pass a key to each item in renderItem

I'm pretty sure the examples need to be updated before this can land, though.

[kesha-antonov]

Hey! @theneva Merged

[Javier-Rotelli]

Great! i'm going to merge this.
@theneva what was the problem you had that you had to downgrade react?

[theneva]

Awesome, thank you!

@Javier-Rotelli the issue is that react-native-mock imports proptypes directly off react, instead of from the prop-types package. That export disappeared from React in 15.6.

15.5 logs warnings during tests but doesn't break.

react-native-mock is unmaintained and it wasn't super easy to get rid of it (I tried replacing mocha with jest to use its built-in mocking, but didn't try mockery which might be worth a look RealOrangeOne/react-native-mock#139 (comment)).

[theneva]

Oh btw @Javier-Rotelli it might be obvious but it hasn't been mentioned explicitly: the change to renderItem makes this a breaking change so it has to be released as a major. Is there anything preventing a release of this?

[Javier-Rotelli]

@theneva not really, other than the time i needed to check if there were breaking changes or not.
i'll make the release and put up issues regarding prop-types and react-native-mock.

[theneva]

@Javier-Rotelli thank you very much! However, it seems like the actual publish to npm didn't go through (and it doesn't look like you're a collaborator on the package). If @mrlaessig gives you the right permissions, will you please try publishing it again? 😄

[Javier-Rotelli]

yup, i need @mrlaessig 's permissions to publish

[mrlaessig]

Hey @Javier-Rotelli what it you npm username?

[Javier-Rotelli]

@mrlaessig -> javierrotelli

[mrlaessig]

@Javier-Rotelli You now should have the permission to do a release on npm ;)