Use single (cached) build for integration tests & release #655
+336
−262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * ci, tests: pass charm artefacts to deploy and test charms This commit enables the "--charm-path" option to pass .charm artefacts to be deployed and tested at an individual level. This change enables the option to pass pre-built charms to the tests to avoid building them on the same test. It also ensures compatibility with the build_charm.py reusable workflow (from canonical/data-platform-workflows). Fixes: canonical#639
There was a problem hiding this comment.
Renamed from release.yaml
Comment on lines
+24
to
+25
| # TODO: use canonical/charming-actions/promote-charm? | ||
| uses: canonical/charming-actions/[email protected] |
There was a problem hiding this comment.
promote-charm looks like a new action that might work better here? not sure
Comment on lines
+10
to
+14
| destination_channel: | ||
| description: CharmHub channel to publish to | ||
| required: false | ||
| default: 'latest/edge' | ||
| type: string |
There was a problem hiding this comment.
is this input ever used? I would imagine you would just dispatch the workflow on the correct branch and then the charming-actions/channel would get the channel right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created as example per request of @NohaIhab