Bugfix/xhr allow authorization header #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this close #580? |
|
Yes, thanks, I've added that to main PR message b/c I'm not clear on whether that auto-close functionality will work from a comment. Fwiw, CI build is failing because of the Grok issue. |
|
Kevin needs to look at this and resolve the broken CI builds. JDKs were updated but that's resulting in broken CI builds. |
ksclarke
force-pushed
the
bugfix/xhr-allow-authorization-header
branch
from
a0ee9ef
to
768b4c0
Compare
…ject#574) Web browser clients implementing IIIF Authentication API 1.0 may send info.json requests with an Authorization header via XMLHttpRequest (XHR). Such requests are "pre-flighted", and the pre-flight response must explicitly state that the Authorization header is allowed in order for the browser to proceed with the request.
ksclarke
force-pushed
the
bugfix/xhr-allow-authorization-header
branch
from
95a1277
to
c3a6e9a
Compare
jcoyne
approved these changes
Aug 16, 2024
jcoyne
requested changes
Aug 28, 2024
src/main/java/edu/illinois/library/cantaloupe/resource/iiif/v1/InformationResource.java
Show resolved
Hide resolved
jcoyne
approved these changes
Sep 25, 2024
DiegoPino
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retargeting the #583 PR to the
developbranch.