Menu buttons guidance PR #4450
Open
Menu buttons guidance PR #4450
+22
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thyhmdo
reviewed
Jan 30, 2025
| | Medium | 40 / 2.5 | | ||
| | Large | 48 / 3 | | ||
|
|
||
| Menu (/components/menu/usage/) items come in four sizes: extra small, small, |
There was a problem hiding this comment.
Suggested change
| Menu (/components/menu/usage/) items come in four sizes: extra small, small, | |
| Menu items come in four sizes: extra small, small, |
| @@ -420,8 +423,10 @@ cases where using a menu button is recommended: | |||
| - Actions related to a common label | |||
| - Distinct actions applied to the same object or page | |||
|
|
|||
| Menu button and combo button come in three different button types: primary, | |||
| tertiary, and ghost. | |||
| Menu button comes in three different button types: | |||
There was a problem hiding this comment.
I think it's redundant to provide links for three button types taking users to the same page. I don't think we use this pattern anywhere either. So maybe:
For detailed visuals, see them in the Style tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4447
Important links: Figma file
Context
[Usage Tab]
[Style Tab]