Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu buttons guidance PR #4450

Closed
wants to merge 3 commits into from
+22 −17
Closed

Menu buttons guidance PR #4450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af5ab1b
menubuttons_pr
alina-jacob-ibm Jan 29, 2025
c109785
fix: ran yarn format
guidari Jan 29, 2025
e773c37
Merge branch 'main' into menubuttons_pr
alina-jacob Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified src/pages/components/menu-buttons/images/style-menu-buttons.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/menu-buttons/images/usage-combo-button-height.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/menu-buttons/images/usage-menu-button-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/menu-buttons/images/usage-menu-combo-button-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/menu-buttons/images/usage-menu-width-menu-button-default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/pages/components/menu-buttons/style.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ The menu used in menu buttons should follow the
### Menu button color

<Row>
<Column colLg={8}>
<Column colLg={12}>

![Menu button variants](images/style-menu-buttons.png)

Expand Down
37 changes: 21 additions & 16 deletions src/pages/components/menu-buttons/usage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,20 @@ A. Icon button <br /> B. Menu <br />

#### Height

Menu items come in four sizes: extra small, small, medium, and large. See more
about size specifications on the [style](/components/menu/style/) tab. When
using a menu button trigger, the height of the menu item (singular) reflects the
size of the button being used.
Menu buttons come in three sizes: small, medium, and large. See more about size
specifications on the [style](/components/menu/style/) tab. When using a menu
button trigger, the height of the menu item (singular) reflects the height of
the button being used.

| Size | Height (px / rem) |
| ------ | ----------------- |
| Small | 32 / 2 |
| Medium | 40 / 2.5 |
| Large | 48 / 3 |

Menu (/components/menu/usage/) items come in four sizes: extra small, small,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Menu (/components/menu/usage/) items come in four sizes: extra small, small,
Menu items come in four sizes: extra small, small,

medium, and large. See more about size specifications on the
[Style](/components/menu/style/) tab.

<InlineNotification>

Expand All @@ -153,17 +163,10 @@ implementation in other contexts if needed.

</InlineNotification>

| Size | Height (px / rem) |
| ----------- | ----------------- |
| Extra small | 24 / 1.5 |
| Small | 32 / 2 |
| Medium | 40 / 2.5 |
| Large | 48 / 3 |

<Row>
<Column colLg={8}>
<Column colLg={12}>

![Menu height](images/usage-menu-button-height.png)
![Menu height](images/usage-combo-button-height.png)

</Column>
</Row>
Expand All @@ -189,7 +192,7 @@ By default, the [menu button](/components/menu-buttons/usage/#menu-button) and
and the menu maintains a minimum width of 160px to prevent a narrow appearance.

<Row>
<Column colLg={8}>
<Column colLg={12}>

![Menu width](images/usage-menu-width-menu-button-default.png)

Expand Down Expand Up @@ -420,8 +423,10 @@ cases where using a menu button is recommended:
- Actions related to a common label
- Distinct actions applied to the same object or page

Menu button and combo button come in three different button types: primary,
tertiary, and ghost.
Menu button comes in three different button types:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's redundant to provide links for three button types taking users to the same page. I don't think we use this pattern anywhere either. So maybe:

For detailed visuals, see them in the Style tab.

[primary](/components/menu-buttons/style/#menu-button-color),
[tertiary](/components/menu-buttons/style/#menu-button-color), and
[ghost](/components/menu-buttons/style/#menu-button-color).

<Row>
<Column colLg={8}>
Expand Down