feat: codemod to enable v12 tile radio icons #18364
Open
+428
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18364 +/- ##
==========================================
- Coverage 84.17% 84.13% -0.04%
==========================================
Files 408 408
Lines 14435 14441 +6
Branches 4660 4643 -17
==========================================
Hits 12150 12150
- Misses 2120 2126 +6
Partials 165 165 ☔ View full report in Codecov by Sentry. |
tay1orjones
requested changes
Jan 17, 2025
packages/upgrade/transforms/__testfixtures__/enable-v12-tile-radio-icons.input.js
Outdated
Show resolved
Hide resolved
Comment on lines
+30
to
+36
| <FeatureFlags someOtherFlag> | ||
| <TileGroup legend="Other Attribute" name="other-wrapped"> | ||
| <RadioTile id="other-1" value="other-1"> | ||
| Other Flag Option 1 | ||
| </RadioTile> | ||
| </TileGroup> | ||
| </FeatureFlags> |
There was a problem hiding this comment.
Tile's unique in that it has 2 javascript flags available right now. Adding another test for enable-v12-tile-default-icons, or changing someOtherFlag to enableV12TileDefaultIcons would make sure future changes here don't alter that specifically.
packages/upgrade/transforms/__tests__/enable-v12-tile-radio-icons-test.js
Show resolved
Hide resolved
…adio-icons.input.js Co-authored-by: Taylor Jones <[email protected]>
Co-authored-by: Taylor Jones <[email protected]>
…ons-test.js Co-authored-by: Taylor Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18350
Enable v12 tile radio icons via feature flags
Changelog
New
Removed
Testing / Reviewing