Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codemod to enable v12 tile radio icons #18364

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+604 −0
Open

feat: codemod to enable v12 tile radio icons #18364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f446a6
feat: codemod to enable v12 tile radio icons
riddhybansal Jan 16, 2025
1d92d9d
fix: test
riddhybansal Jan 16, 2025
1b4dc82
Update packages/upgrade/transforms/__testfixtures__/enable-v12-tile-r…
riddhybansal Jan 17, 2025
209e47f
Update packages/upgrade/transforms/enable-v12-tile-radio-icons.js
riddhybansal Jan 17, 2025
117bee8
Update packages/upgrade/transforms/__tests__/enable-v12-tile-radio-ic…
riddhybansal Jan 17, 2025
21c78b2
fix: added tsx fixtures
riddhybansal Jan 21, 2025
a430936
fix: test cases
riddhybansal Jan 23, 2025
ce3df8d
fix: test cases
riddhybansal Jan 28, 2025
f80357c
Merge branch 'main' into codemod_to_enable_radio_tile_icon
riddhybansal Jan 28, 2025
6c813c8
fix: formatting issues
riddhybansal Jan 28, 2025
6ccd220
fix: formatting issues
riddhybansal Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ packages/**/examples/**
# Upgrade
packages/upgrade/cli.js
packages/upgrade/**/*.output.js
packages/upgrade/**/*.output.tsx

# Accessibility Verification Testing
**/.avt/**
60 changes: 60 additions & 0 deletions packages/upgrade/src/upgrades.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,66 @@
});
},
},
{
name: 'enable-v12-tile-radio-icons',
description: `
Wrap RadioTile components with FeatureFlags enableV12TileRadioIcons

Transforms:

1. TileGroup with RadioTile:
<TileGroup>
<RadioTile>...</RadioTile>
</TileGroup>

Into:
<FeatureFlags enableV12TileRadioIcons>
<TileGroup>
<RadioTile>...</RadioTile>
</TileGroup>
</FeatureFlags>

2. Standalone RadioTile:
<RadioTile>...</RadioTile>

Into:
<FeatureFlags enableV12TileRadioIcons>
<RadioTile>...</RadioTile>
</FeatureFlags>
`,

migrate: async (options) => {
const transform = path.join(

Check warning on line 400 in packages/upgrade/src/upgrades.js

View check run for this annotation

Codecov / codecov/patch

packages/upgrade/src/upgrades.js#L399-L400 

Added lines #L399 - L400 were not covered by tests
TRANSFORM_DIR,
'enable-v12-tile-radio-icons.js'
);
const paths =
Array.isArray(options.paths) && options.paths.length > 0
? options.paths
: await glob(['**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx'], {

Check warning on line 407 in packages/upgrade/src/upgrades.js

View check run for this annotation

Codecov / codecov/patch

packages/upgrade/src/upgrades.js#L406-L407 

Added lines #L406 - L407 were not covered by tests
cwd: options.workspaceDir,
ignore: [
'**/es/**',
'**/lib/**',
'**/umd/**',
'**/node_modules/**',
'**/storybook-static/**',
'**/dist/**',
'**/build/**',
'**/*.d.ts',
'**/coverage/**',
],
});

await run({

Check warning on line 422 in packages/upgrade/src/upgrades.js

View check run for this annotation

Codecov / codecov/patch

packages/upgrade/src/upgrades.js#L422 

Added line #L422 was not covered by tests
dry: !options.write,
transform,
paths,
verbose: options.verbose,
parser: 'tsx', // Enable parsing of TSX files
});
},
},
{
name: 'refactor-to-callout',
description:
Expand Down
87 changes: 87 additions & 0 deletions packages/upgrade/transforms/__testfixtures__/enable-v12-tile-radio-icons.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import React from 'react';
import { TileGroup, RadioTile, Stack } from '@carbon/react';
import { FeatureFlags } from '@carbon/feature-flags';

function TestComponent() {
return (
//prettier-ignore
<div>
{/* Case 1: Unwrapped TileGroup */}
<TileGroup legend="TestGroup" name="test">
<RadioTile id="test-1" value="test-1">
Option 1
</RadioTile>
<RadioTile id="test-2" value="test-2">
Option 2
</RadioTile>
</TileGroup>
{/* Wrapped standalone missing flag prop */}
<FeatureFlags>
<TileGroup legend="Missing Attribute" name="wrapped">
<RadioTile id="wrapped-1" value="wrapped-1">
Already Wrapped Option 1
</RadioTile>
<RadioTile id="wrapped-2" value="wrapped-2">
Already Wrapped Option 2
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 3: Already wrapped with other attributes */}
<FeatureFlags enable-v12-tile-default-icons>
<TileGroup legend="Other Attribute" name="other-wrapped">
<RadioTile id="other-1" value="other-1">
Other Flag Option 1
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 4: Already wrapped with correct attribute */}
<FeatureFlags enableV12TileRadioIcons>
<TileGroup legend="Correct Wrapped" name="correct">
<RadioTile id="correct-1" value="correct-1">
Correctly Wrapped Option
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 5: Standalone RadioTiles with different scenarios */}
<Stack>
{/* Unwrapped standalone */}
<RadioTile id="standalone" value="standalone">
Standalone Tile
</RadioTile>
{/* Wrapped standalone missing flag prop */}
<FeatureFlags>
<RadioTile id="wrapped-standalone" value="wrapped-standalone">
Wrapped Standalone
</RadioTile>
</FeatureFlags>
{/* Wrapped standalone with other flag */}
<FeatureFlags enable-v12-tile-default-icons>
<RadioTile id="other-standalone" value="other-standalone">
Other Flag Standalone
</RadioTile>
</FeatureFlags>
{/* Correctly wrapped standalone */}
<FeatureFlags enableV12TileRadioIcons>
<RadioTile id="correct-standalone" value="correct-standalone">
Correct Standalone
</RadioTile>
</FeatureFlags>
</Stack>
{/* Case 6: Nested structures */}
<div className="nested">
<TileGroup legend="Nested Group" name="nested">
<div className="wrapper">
<RadioTile id="nested-1" value="nested-1">
Nested Option 1
</RadioTile>
</div>
<RadioTile id="nested-2" value="nested-2">
Nested Option 2
</RadioTile>
</TileGroup>
</div>
</div>
);
}

export default TestComponent;
87 changes: 87 additions & 0 deletions packages/upgrade/transforms/__testfixtures__/enable-v12-tile-radio-icons.input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import React from 'react';
import { TileGroup, RadioTile, Stack } from '@carbon/react';
import { FeatureFlags } from '@carbon/feature-flags';

const TestComponent: React.FC = () => {
return (
//prettier-ignore
<div>
{/* Case 1: Unwrapped TileGroup */}
<TileGroup legend="TestGroup" name="test">
<RadioTile id="test-1" value="test-1">
Option 1
</RadioTile>
<RadioTile id="test-2" value="test-2">
Option 2
</RadioTile>
</TileGroup>
{/* Wrapped standalone missing flag prop */}
<FeatureFlags>
<TileGroup legend="Missing Attribute" name="wrapped">
<RadioTile id="wrapped-1" value="wrapped-1">
Already Wrapped Option 1
</RadioTile>
<RadioTile id="wrapped-2" value="wrapped-2">
Already Wrapped Option 2
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 3: Already wrapped with other flags */}
<FeatureFlags enable-v12-tile-default-icons>
<TileGroup legend="Other Attribute" name="other-wrapped">
<RadioTile id="other-1" value="other-1">
Other Flag Option 1
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 4: Already wrapped with correct flag */}
<FeatureFlags enableV12TileRadioIcons>
<TileGroup legend="Correct Wrapped" name="correct">
<RadioTile id="correct-1" value="correct-1">
Correctly Wrapped Option
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 5: Standalone RadioTiles with different scenarios */}
<Stack>
{/* Unwrapped standalone */}
<RadioTile id="standalone" value="standalone">
Standalone Tile
</RadioTile>
{/* Wrapped standalone missing flag prop */}
<FeatureFlags>
<RadioTile id="wrapped-standalone" value="wrapped-standalone">
Wrapped Standalone
</RadioTile>
</FeatureFlags>
{/* Wrapped standalone with other flag */}
<FeatureFlags enable-v12-tile-default-icons>
<RadioTile id="other-standalone" value="other-standalone">
Other Flag Standalone radio
</RadioTile>
</FeatureFlags>
{/* Correctly wrapped standalone */}
<FeatureFlags enableV12TileRadioIcons>
<RadioTile id="correct-standalone" value="correct-standalone">
Correct Standalone
</RadioTile>
</FeatureFlags>
</Stack>
{/* Case 6: Nested structures */}
<div className="nested">
<TileGroup legend="Nested Group" name="nested">
<div className="wrapper">
<RadioTile id="nested-1" value="nested-1">
Nested Option 1
</RadioTile>
</div>
<RadioTile id="nested-2" value="nested-2">
Nested Option 2
</RadioTile>
</TileGroup>
</div>
</div>
);
};

export default TestComponent;
87 changes: 87 additions & 0 deletions packages/upgrade/transforms/__testfixtures__/enable-v12-tile-radio-icons.output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import React from 'react';
import { TileGroup, RadioTile, Stack } from '@carbon/react';
import { FeatureFlags } from '@carbon/feature-flags';

function TestComponent() {
return (
//prettier-ignore
(<div>
{/* Case 1: Unwrapped TileGroup */}
<FeatureFlags enableV12TileRadioIcons><TileGroup legend="TestGroup" name="test">
<RadioTile id="test-1" value="test-1">
Option 1
</RadioTile>
<RadioTile id="test-2" value="test-2">
Option 2
</RadioTile>
</TileGroup></FeatureFlags>
{/* Wrapped standalone missing flag prop */}
<FeatureFlags enableV12TileRadioIcons>
<TileGroup legend="Missing Attribute" name="wrapped">
<RadioTile id="wrapped-1" value="wrapped-1">
Already Wrapped Option 1
</RadioTile>
<RadioTile id="wrapped-2" value="wrapped-2">
Already Wrapped Option 2
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 3: Already wrapped with other attributes */}
<FeatureFlags enable-v12-tile-default-icons enableV12TileRadioIcons>
<TileGroup legend="Other Attribute" name="other-wrapped">
<RadioTile id="other-1" value="other-1">
Other Flag Option 1
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 4: Already wrapped with correct attribute */}
<FeatureFlags enableV12TileRadioIcons>
<TileGroup legend="Correct Wrapped" name="correct">
<RadioTile id="correct-1" value="correct-1">
Correctly Wrapped Option
</RadioTile>
</TileGroup>
</FeatureFlags>
{/* Case 5: Standalone RadioTiles with different scenarios */}
<Stack>
{/* Unwrapped standalone */}
<FeatureFlags enableV12TileRadioIcons><RadioTile id="standalone" value="standalone">
Standalone Tile
</RadioTile></FeatureFlags>
{/* Wrapped standalone missing flag prop */}
<FeatureFlags enableV12TileRadioIcons>
<RadioTile id="wrapped-standalone" value="wrapped-standalone">
Wrapped Standalone
</RadioTile>
</FeatureFlags>
{/* Wrapped standalone with other flag */}
<FeatureFlags enable-v12-tile-default-icons enableV12TileRadioIcons>
<RadioTile id="other-standalone" value="other-standalone">
Other Flag Standalone
</RadioTile>
</FeatureFlags>
{/* Correctly wrapped standalone */}
<FeatureFlags enableV12TileRadioIcons>
<RadioTile id="correct-standalone" value="correct-standalone">
Correct Standalone
</RadioTile>
</FeatureFlags>
</Stack>
{/* Case 6: Nested structures */}
<div className="nested">
<FeatureFlags enableV12TileRadioIcons><TileGroup legend="Nested Group" name="nested">
<div className="wrapper">
<RadioTile id="nested-1" value="nested-1">
Nested Option 1
</RadioTile>
</div>
<RadioTile id="nested-2" value="nested-2">
Nested Option 2
</RadioTile>
</TileGroup></FeatureFlags>
</div>
</div>)
);
}

export default TestComponent;
Loading
Loading