-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add autoAlign to inner IconButton #18533
fix: add autoAlign to inner IconButton #18533
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18533 +/- ##
==========================================
+ Coverage 84.10% 84.11% +0.01%
==========================================
Files 408 408
Lines 14466 14466
Branches 4656 4676 +20
==========================================
+ Hits 12166 12168 +2
+ Misses 2134 2132 -2
Partials 166 166 ☔ View full report in Codecov by Sentry. |
@tay1orjones Apologies for the recreate. My Git client combined with my inexperience with git completely ruined the commits on the last one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know on the previous PR I said we might want to add this as a prop, but looking at it closer now I think it's fine to hardcode this for now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariellalgilmore pointed out to me that other
is already spread on IconButton, so setting autoAlign
on OverflowMenu should trickle down to IconButton without needing to hardcode it like this.
https://stackblitz.com/edit/jsesilma?file=src%2Findex.scss,src%2FApp.jsx
Does that work in your use case?
I can confirm this works for us. Shall I close this PR? |
Closes #17305
Added the autoAlign prop to allow the inner IconButton to use the floating-ui component. This allows for the tooltip popover to render over the table rather than inside it, preventing the overflow scrollbar from appearing.
Changelog
Changed
autoAlign={true}
prop to inner IconButton in OverflowMenuTesting / Reviewing