Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add autoAlign to inner IconButton #18533

Closed
wants to merge 1 commit into from
Closed

fix: add autoAlign to inner IconButton #18533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ exports[`DataTable behaves as expected selection should render and match snapsho
class="cds--overflow-menu__wrapper"
>
<span
class="cds--popover-container cds--popover--caret cds--popover--high-contrast cds--popover--top cds--tooltip cds--icon-tooltip"
class="cds--popover-container cds--popover--caret cds--popover--high-contrast cds--popover--auto-align cds--autoalign cds--popover--top cds--tooltip cds--icon-tooltip"
>
<div
class="cds--tooltip-trigger__wrapper"
Expand Down Expand Up @@ -617,12 +617,13 @@ exports[`DataTable behaves as expected selection should render and match snapsho
>
<span
class="cds--popover-content cds--tooltip-content"
style="position: fixed; left: 0px; top: 0px; visibility: visible; transform: translate(0px, 0px);"
>
Settings
<span
class="cds--popover-caret cds--popover--auto-align"
/>
</span>
<span
class="cds--popover-caret"
/>
</span>
</span>
</span>
Expand Down Expand Up @@ -1012,7 +1013,7 @@ exports[`DataTable renders as expected - Component API should render and match s
class="cds--overflow-menu__wrapper"
>
<span
class="cds--popover-container cds--popover--caret cds--popover--high-contrast cds--popover--top cds--tooltip cds--icon-tooltip"
class="cds--popover-container cds--popover--caret cds--popover--high-contrast cds--popover--auto-align cds--autoalign cds--popover--top cds--tooltip cds--icon-tooltip"
>
<div
class="cds--tooltip-trigger__wrapper"
Expand Down Expand Up @@ -1054,12 +1055,13 @@ exports[`DataTable renders as expected - Component API should render and match s
>
<span
class="cds--popover-content cds--tooltip-content"
style="position: fixed; left: 0px; top: 0px; visibility: visible; transform: translate(0px, 0px);"
>
Settings
<span
class="cds--popover-caret cds--popover--auto-align"
/>
</span>
<span
class="cds--popover-caret"
/>
</span>
</span>
</span>
Expand Down
9 changes: 5 additions & 4 deletions ...ages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`TableToolbarMenu renders as expected - Component API should render 1`]
class="cds--overflow-menu__wrapper"
>
<span
class="cds--popover-container cds--popover--caret cds--popover--high-contrast cds--popover--top cds--tooltip cds--icon-tooltip"
class="cds--popover-container cds--popover--caret cds--popover--high-contrast cds--popover--auto-align cds--autoalign cds--popover--top cds--tooltip cds--icon-tooltip"
>
<div
class="cds--tooltip-trigger__wrapper"
Expand Down Expand Up @@ -45,12 +45,13 @@ exports[`TableToolbarMenu renders as expected - Component API should render 1`]
>
<span
class="cds--popover-content cds--tooltip-content"
style="position: fixed; left: 0px; top: 0px; visibility: visible; transform: translate(0px, 0px);"
>
Add
<span
class="cds--popover-caret cds--popover--auto-align"
/>
</span>
<span
class="cds--popover-caret"
/>
</span>
</span>
</span>
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/components/OverflowMenu/OverflowMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,7 @@ class OverflowMenu extends React.Component<
aria-haspopup
aria-expanded={open}
aria-controls={open ? menuBodyId : undefined}
autoAlign={true}
className={overflowMenuClasses}
onClick={this.handleClick}
id={id}
Expand Down
Loading