Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to anthropic/claude-3.5-sonnet in code mode #2081

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Default to anthropic/claude-3.5-sonnet in code mode #2081

wants to merge 13 commits into from
+63 −1

Conversation

jurgenwerk
Copy link
Contributor

@jurgenwerk jurgenwerk commented Jan 23, 2025 •
edited
Loading

No description provided.

@jurgenwerk jurgenwerk added the parked Inactive but useful to have it open label Jan 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Host Test Results

    1 files  ±0      1 suites  ±0   23m 29s ⏱️ +49s
748 tests +5  746 ✔️ +5  2 💤 ±0  0 ❌ ±0 
753 runs  +5  751 ✔️ +5  2 💤 ±0  0 ❌ ±0 

Results for commit 9f91597. ± Comparison against base commit e702fc0.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both. 
Chrome 132.0 ‑ Integration | code-submode | playground panel: can render playground panel

Chrome 132.0 ‑ Acceptance | AI Assistant tests: defaults to anthropic/claude-3.5-sonnet in code mode
Chrome 132.0 ‑ Acceptance | code-submode | playground panel: can render playground panel when a card def is selected
Chrome 132.0 ‑ Acceptance | code-submode | playground panel: can select from available instances using the instance chooser
Chrome 132.0 ‑ Acceptance | code-submode | playground panel: can update the instance chooser when a different file is opened
Chrome 132.0 ‑ Acceptance | code-submode | playground panel: can update the instance chooser when selected card def changes (same file)
Chrome 132.0 ‑ Integration | card api (Usage of publicAPI actions) > getCards: changing query updates search resource

♻️ This comment has been updated with latest results.

@jurgenwerk jurgenwerk marked this pull request as ready for review January 28, 2025 10:43
@jurgenwerk jurgenwerk changed the title Default to sonnet in code mode Default to anthropic/claude-3.5-sonnet in code mode Jan 28, 2025
@jurgenwerk jurgenwerk removed the parked Inactive but useful to have it open label Jan 28, 2025
lukemelia
lukemelia reviewed Jan 28, 2025
View reviewed changes
packages/host/app/components/matrix/room.gts Outdated
@@ -239,6 +241,24 @@ export default class Room extends Component<Signature> {
registerDestructor(this, () => {
this.scrollState().messageVisibilityObserver.disconnect();
});

this.setRoomLLM();
Copy link
Contributor

@lukemelia lukemelia Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it running in the constructor of the room component. It seems like a surprising place to me that might miss certain cases. For example, creating a new room, or switching rooms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning behind doing it this way is because I thought this made sense only for newly created rooms. But now I see it would be better to support switching rooms too, and move the logic out of the constructor. This is now fixed in later commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemelia lukemelia lukemelia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurgenwerk @lukemelia