-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to anthropic/claude-3.5-sonnet in code mode #2081
Open
jurgenwerk
wants to merge
13
commits into
main
Choose a base branch
from
cs-7859-default-code-modes-ai-assistant-to-sonnet-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−1
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
29b2339
Default to sonnet in code mode
jurgenwerk 9427e45
Merge branch 'main' into cs-7859-default-code-modes-ai-assistant-to-s…
jurgenwerk 77ed354
Merge branch 'cs-7847-bug-sonnet-breaks-if-you-send-it-a-list-of-mess…
jurgenwerk 4c2854a
Lint fix
jurgenwerk 6760e33
Add test
jurgenwerk b588ff9
Merge branch 'main' into cs-7859-default-code-modes-ai-assistant-to-s…
jurgenwerk d3eb361
Merge branch 'main' into cs-7859-default-code-modes-ai-assistant-to-s…
jurgenwerk 731e33f
Cleanup
jurgenwerk c6fe788
Default to sonnet when switching the room in code mode
jurgenwerk 63c9855
Not needed
jurgenwerk 36af492
Lint
jurgenwerk 240e786
Fix order
jurgenwerk 9f91597
Improve test
jurgenwerk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it running in the constructor of the room component. It seems like a surprising place to me that might miss certain cases. For example, creating a new room, or switching rooms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning behind doing it this way is because I thought this made sense only for newly created rooms. But now I see it would be better to support switching rooms too, and move the logic out of the constructor. This is now fixed in later commits