Make asset checks run in integration test #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdangerx
force-pushed
the
3928-asset-checks-run-again
branch
from
70ceddc to
11ccfbe
Compare
jdangerx
force-pushed
the
3928-asset-checks-run-again
branch
from
11ccfbe to
ab560e3
Compare
…set-check-fix Fix FERC714 fast CI asset check
jdangerx
changed the title
…allow test to specify job name.
bendnorman
approved these changes
Dec 22, 2024
Comment on lines
-53
to
-57
| return Definitions( | ||
| assets=pudl.etl.default_assets, | ||
| resources=pudl.etl.default_resources, | ||
| jobs=jobs, | ||
| ).get_job_def("etl_job") |
There was a problem hiding this comment.
Oh I see... we redefined the definitions here but didn't add the asset checks so they weren't getting run. Importing defs from pudl.etl includes the assets checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3928 .
What problem does this address?
#3711 inadvertently disabled the asset checks again, in service of fixing
pudl_etl😞Getting rid of
pudl_etl(#3161) seemed out of scope here, but I made the tests use the sameDefinitionsas the nightly builds again.Testing
How did you make sure this worked? How can a reviewer verify this?
Made the pandera checks all fail, ran
make integration-test, and checked to make sure that the integration tests bailed out once we ran into a failure.Then got other people to fix the failing asset checks and re-ran integration tests. They passed.
To-do list