-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BrukerTiffImagingExtractor
#230
Conversation
for more information, see https://pre-commit.ci
Thanks @weiglszonja Going to enlist the help of @pauladkisson to help review this PR to get them some more experience with the workflow of managing this repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look pretty reasonable to me. It looks like CI checks are failing due to file/path issues, could you clear that up? Or if you're using a file that isn't in the ophys testing repo, we should probably add it.
Thanks @pauladkisson, the PR for uploading the test data is here, once it's merged hopefully the tests will pass. |
Notes for Bruker version (can be checked in the XML file)
Adding @h-mayorquin to this thread as he is also working with dual channel data. |
…r' into update_BrukerTiffImagingExtractor
for more information, see https://pre-commit.ci
Unfortunately it looks like @h-mayorquin's data, though it was originally Bruker output, was converted into another format (nifty) after acquisition (and source was not kept) so the example data we have here is from Pinto lab and the NWB helpdesk (best volumetric example so far) |
…r' into update_BrukerTiffImagingExtractor # Conflicts: # src/roiextractors/extractors/tiffimagingextractors/brukertiffimagingextractor.py # tests/test_brukertiffimagingextactor.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…r' into update_BrukerTiffImagingExtractor
for more information, see https://pre-commit.ci
LGTM! Thanks for all the hard work on this |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 76.15% 77.13% +0.98%
==========================================
Files 37 37
Lines 2583 2725 +142
==========================================
+ Hits 1967 2102 +135
- Misses 616 623 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Update
BrukerTiffImagingExtractor
to handle the additional types of Bruker data (volumetric, multi color, stimulation)WIP