Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: source references #103

Open
gordonkoehn opened this issue Feb 21, 2025 · 1 comment
Open

feature: source references #103

gordonkoehn opened this issue Feb 21, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gordonkoehn
Copy link
Collaborator

gordonkoehn commented Feb 21, 2025

sr2silo needs aminod acid references for SILO and for diamondX.

These have to be of the very same at V-Pipe and SILO.

It is probably best to get them from SILO / Pathoplexus as they also have amino acids.

And compare the nucliotide reference against V-Pipe, in unittests.


The current reference is from NIH, and manually reformated for use in Blast/Diamond.
The resoeuces in references should be filled from nextclade or genspectrum.

@gordonkoehn gordonkoehn self-assigned this Feb 21, 2025
@gordonkoehn gordonkoehn changed the title feature: pull and reformat reference from nextclade feature: pull reference from nextclade Mar 3, 2025
@gordonkoehn gordonkoehn changed the title feature: pull reference from nextclade feature: source references Mar 6, 2025
@gordonkoehn
Copy link
Collaborator Author

This PR should fetch references from:

curl -X 'GET' \
  'https://lapis.pathoplexus.org/cchf/sample/referenceGenome?downloadAsFile=false' \
  -H 'accept: application/json'

Or from Covspectrum for now:


curl -X 'GET' \
  'https://lapis.cov-spectrum.org/gisaid/v2/sample/referenceGenome?downloadAsFile=false' \
  -H 'accept: application/json'

remove the current, https://github.com/cbg-ethz/sr2silo/blob/main/resources/sars-cov-2/reference_genomes.json

Remove this outdated one.
https://github.com/cbg-ethz/sr2silo/blob/main/resources/sars-cov-2/NC_045512.2.fasta

And decide whether to keep or not the resource folder. Probably remove / and add an argument to the CLI to show the reference used. Download it to run offline.

@gordonkoehn gordonkoehn added the enhancement New feature or request label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant