This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-table] Table section header fix #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
reviewed
Nov 29, 2023
|
|
||
| &.last-pinned-column { | ||
| border-right: var(--terra-table-last-pinned-header-border-right, 2px solid #808080); | ||
| box-shadow: var(--terra-table-last-pinned-header-box-shadow, 2px -1px 6px #808080); |
There was a problem hiding this comment.
Are we sure we don't want the box shadow over all the pinned columns? I'm looking at the snapshot results in this PR and it's much harder to tell where the pinned columns start and end now. Looking at the number of snaps that are being changed this is actually quite a big change.
There was a problem hiding this comment.
This change was specified by @eawww after consulting with additional UX associates.
| --terra-table-pinned-columns-divider-box-shadow: 4px -1px 6px #181b1d; | ||
| // Pinned Columns Divider | ||
| --terra-table-last-pinned-header-border-right: 2px solid #181b1d; | ||
| --terra-table-last-pinned-header-box-shadow: 2px -1px 6px #181b1d; |
There was a problem hiding this comment.
Same concern here as was in the main column header cell file: I'm seeing a lot of the box shadows removed from the divider.
There was a problem hiding this comment.
This change was specified by @eawww after consulting with additional UX associates.
adoroshk
approved these changes
Nov 30, 2023
eawww
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The Terra Table was updated so that the section headers would not scroll off the screen. The implementation of the pinned column divider was updated so that it would not overlay the section headers.
Why it was changed:
The change was made so that the section header title would always be visible to users.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-9898
Thank you for contributing to Terra.
@cerner/terra