Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-table] Table section header fix #1918

Merged
merged 4 commits into from
Nov 30, 2023
Merged

[terra-table] Table section header fix #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb7de39
[terra-table] Prevent section headers from scrolling
cm9361 Nov 29, 2023
3f42a2e
Merge remote-tracking branch 'origin' into table-section-header-fix
cm9361 Nov 29, 2023
3624bdf
[terra-table] Prevent section headers from scrolling
cm9361 Nov 29, 2023
1290f0f
Update Changelog
cm9361 Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
24 changes: 12 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

76 changes: 20 additions & 56 deletions packages/terra-data-grid/tests/jest/__snapshots__/DataGrid.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
width={200}
>
<th
className="column-header selectable pinned"
className="column-header selectable pinned last-pinned-column"
id="test-terra-data-grid-table-Column-1"
key="Column-1"
onKeyDown={[Function]}
Expand Down Expand Up @@ -887,15 +887,6 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
/>
</ColumnResizeHandle>
</InjectIntl(ColumnResizeHandle)>
<div
className="pinned-columns-divider"
style={
Object {
"height": 0,
"left": 199,
}
}
/>
</th>
</ColumnHeaderCell>
</InjectIntl(ColumnHeaderCell)>
Expand Down Expand Up @@ -1412,7 +1403,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable blank"
className="cell pinned last-pinned-column selectable blank"
headers="test-terra-data-grid-table-rowheader-1 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -1764,7 +1755,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-2 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -2112,7 +2103,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-3 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -2460,7 +2451,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable highlighted"
className="cell pinned last-pinned-column selectable highlighted"
headers="test-terra-data-grid-table-rowheader-4 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -3417,7 +3408,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
width={200}
>
<th
className="column-header selectable pinned"
className="column-header selectable pinned last-pinned-column"
id="test-terra-data-grid-table-Column-1"
key="Column-1"
onKeyDown={[Function]}
Expand Down Expand Up @@ -3535,15 +3526,6 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
/>
</ColumnResizeHandle>
</InjectIntl(ColumnResizeHandle)>
<div
className="pinned-columns-divider"
style={
Object {
"height": 0,
"left": 199,
}
}
/>
</th>
</ColumnHeaderCell>
</InjectIntl(ColumnHeaderCell)>
Expand Down Expand Up @@ -4060,7 +4042,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable blank"
className="cell pinned last-pinned-column selectable blank"
headers="test-terra-data-grid-table-rowheader-1 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -4412,7 +4394,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-2 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -4760,7 +4742,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-3 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -5108,7 +5090,7 @@ exports[`DataGrid verifies onCellSelect callback is triggered when space is pres
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable highlighted"
className="cell pinned last-pinned-column selectable highlighted"
headers="test-terra-data-grid-table-rowheader-4 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -6186,7 +6168,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
width={200}
>
<th
className="column-header selectable pinned"
className="column-header selectable pinned last-pinned-column"
id="test-terra-data-grid-table-Column-1"
key="Column-1"
onKeyDown={[Function]}
Expand Down Expand Up @@ -6304,15 +6286,6 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
/>
</ColumnResizeHandle>
</InjectIntl(ColumnResizeHandle)>
<div
className="pinned-columns-divider"
style={
Object {
"height": 0,
"left": 199,
}
}
/>
</th>
</ColumnHeaderCell>
</InjectIntl(ColumnHeaderCell)>
Expand Down Expand Up @@ -6996,7 +6969,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable blank"
className="cell pinned last-pinned-column selectable blank"
headers="test-terra-data-grid-table-rowheader-1 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -7508,7 +7481,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-2 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -8016,7 +7989,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-3 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -8524,7 +8497,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable highlighted"
className="cell pinned last-pinned-column selectable highlighted"
headers="test-terra-data-grid-table-rowheader-4 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -9460,7 +9433,7 @@ exports[`DataGrid verifies that the grid created is consistent with the rows and
width={200}
>
<th
className="column-header selectable pinned"
className="column-header selectable pinned last-pinned-column"
id="test-terra-data-grid-table-Column-1"
key="Column-1"
onKeyDown={[Function]}
Expand Down Expand Up @@ -9578,15 +9551,6 @@ exports[`DataGrid verifies that the grid created is consistent with the rows and
/>
</ColumnResizeHandle>
</InjectIntl(ColumnResizeHandle)>
<div
className="pinned-columns-divider"
style={
Object {
"height": 0,
"left": 199,
}
}
/>
</th>
</ColumnHeaderCell>
</InjectIntl(ColumnHeaderCell)>
Expand Down Expand Up @@ -10103,7 +10067,7 @@ exports[`DataGrid verifies that the grid created is consistent with the rows and
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable blank"
className="cell pinned last-pinned-column selectable blank"
headers="test-terra-data-grid-table-rowheader-1 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -10455,7 +10419,7 @@ exports[`DataGrid verifies that the grid created is consistent with the rows and
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-2 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -10803,7 +10767,7 @@ exports[`DataGrid verifies that the grid created is consistent with the rows and
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable"
className="cell pinned last-pinned-column selectable"
headers="test-terra-data-grid-table-rowheader-3 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down Expand Up @@ -11151,7 +11115,7 @@ exports[`DataGrid verifies that the grid created is consistent with the rows and
tableId="test-terra-data-grid-table"
>
<td
className="cell pinned selectable highlighted"
className="cell pinned last-pinned-column selectable highlighted"
headers="test-terra-data-grid-table-rowheader-4 test-terra-data-grid-table-Column-1"
onKeyDown={[Function]}
onMouseDown={[Function]}
Expand Down
Loading
Loading