This repository has been archived by the owner on May 24, 2024. It is now read-only.
Modal manager redwood styling #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm9361
reviewed
Jan 18, 2024
package.json
Outdated
| @@ -45,7 +45,7 @@ | |||
| }, | |||
| "overrides": [ | |||
| { | |||
| "files": ["packages/terra-theme-properties/**/*.scss"], | |||
| "files": ["packages/terra-theme-properties/**/*.scss", "packages/**/redwood-theme/*.scss"], | |||
There was a problem hiding this comment.
I think you want "...redwood-theme/**/*.scss"
There was a problem hiding this comment.
Good catch, fixed in dcf6be0
cm9361
reviewed
Jan 18, 2024
| @@ -323,13 +323,14 @@ | |||
|
|
|||
| // ======================================= | |||
| // terra-modal-manager | |||
| // https://github.com/cerner/terra-core/tree/main/packages/terra-modal-manager | |||
| // https://github.com/cerner/terra-framework/tree/main/packages/terra-modal-manager | |||
There was a problem hiding this comment.
These files are generated. I communicated this issue with the UX team. You don't want to manually update it as it would just be incorrect the next release.
There was a problem hiding this comment.
Awesome, thank you so much for taking care of that, reverted in dcf6be0
cm9361
reviewed
Jan 18, 2024
| // https://jira2.cerner.com/browse/UXPLATFORM-10006 | ||
| // ======================================= | ||
| .redwood-theme { | ||
| --modal-background-color: var(--container-style-1-background-color); | ||
| --modal-box-shadow: var(--rds-box-shadow-md); | ||
| --modal-border-radius: var(--rds-border-radius-md); | ||
| // TODO add --modal-foreground-color variable or remove this line is inherit color works |
There was a problem hiding this comment.
I still think we don't want a UX theme variable here.
There was a problem hiding this comment.
Removed here: dcf6be0
sycombs
reviewed
Jan 19, 2024
sycombs
approved these changes
Jan 19, 2024
cm9361
approved these changes
Jan 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds redwood styling to the modal manager and adds wdio screenshots for that component.
NOTE: the redwood css styles that changed are border radius, background color and box-shadow css props of the disclosure modal, the content of the disclosure component is not impacted by the change. The wdio screenshots will need to be updated once the content components become redwood-styled.
Testing
This change was tested using:
Steps to test:
npm cito build and generate css styles for all themes.<div>.Reviews
In addition to engineering reviews, this PR needs:
This PR resolves:
UXPLATFORM-10006