This repository has been archived by the owner on May 24, 2024. It is now read-only.
Modal manager redwood styling #1994
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,9 @@ | |
|
|
||
| ## Unreleased | ||
|
|
||
| * Added | ||
| * Redwood theme styling. | ||
|
|
||
| ## 6.69.0 - (December 18, 2023) | ||
|
|
||
| * Changed | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| :local { | ||
| .redwood-theme { | ||
| --terra-modal-manager-background-color: var(--modal-background-color); | ||
| --terra-modal-manager-border: none; | ||
| --terra-modal-manager-border-radius: var(--modal-border-radius); | ||
| --terra-modal-manager-box-shadow: var(--modal-box-shadow); | ||
| --terra-modal-manager-foreground-color: inherit; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -323,13 +323,14 @@ | |
|
|
||
| // ======================================= | ||
| // terra-modal-manager | ||
| // https://github.com/cerner/terra-framework/tree/main/packages/terra-modal-manager | ||
|
There was a problem hiding this comment. These files are generated. I communicated this issue with the UX team. You don't want to manually update it as it would just be incorrect the next release. There was a problem hiding this comment. Awesome, thank you so much for taking care of that, reverted in dcf6be0 |
||
| // https://jira2.cerner.com/browse/UXPLATFORM-10006 | ||
| // ======================================= | ||
| .redwood-theme { | ||
| --modal-background-color: var(--container-style-1-background-color); | ||
| --modal-box-shadow: var(--rds-box-shadow-md); | ||
| --modal-border-radius: var(--rds-border-radius-md); | ||
| // TODO add --modal-foreground-color variable or remove this line is inherit color works | ||
|
There was a problem hiding this comment. I still think we don't want a UX theme variable here. There was a problem hiding this comment. Removed here: dcf6be0 |
||
| } | ||
|
|
||
| // ======================================= | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want "...redwood-theme/**/*.scss"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in dcf6be0